- Issue created by @Anybody
- 🇩🇪Germany Anybody Porta Westfalica
I think the implementation isn't complete.
$fieldValue
is a Drupal\Core\Field\FieldItemList and we don't get the value correctly, as it seems.$fieldValue->orderable
can't work here, I guess. It's different from the Devel output on the commerce product variation entity.
- 🇩🇪Germany Anybody Porta Westfalica
This FOR SURE wasn't tested well enough :P
See MR. Now it works as expected.
- Status changed to Needs review
8 months ago 4:07pm 19 August 2024 - Merge request !13Fix commerce_product_availability.module orderability checks → (Merged) created by Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Works perfectly now! Merging the hotfix and tagging a new release!
- Issue was unassigned.
- Status changed to Fixed
8 months ago 4:12pm 19 August 2024 - 🇩🇪Germany Grevil
I feel like somehow, somewhere, a LOT of code of this module got lost.
First the completely incorrect alter hook, that doesn't do anything, now this...
Doesn't make sense to me. Changes suggest, that this wasn't tested at all! But it was. Doesn't make sense to me... my apologies! Automatically closed - issue fixed for 2 weeks with no activity.