- Issue created by @catch
- Status changed to Needs review
8 months ago 6:01am 19 August 2024 - 🇬🇧United Kingdom catch
Made a branch where phpstan fails - you can see that the Test jobs all start, but then get cancelled because the phpstan job fails. In this case it was within a few seconds of each other (hard to tell unless watching it live) which means the Test jobs didn't start a pod yet. https://git.drupalcode.org/project/drupal/-/pipelines/257801
This means we get the benefit of the lint jobs preventing a full test run if they fail without having to wait for every single test to finish.
- Merge request !9249Trigger the child job as soon as phpcs and cspell have run. → (Closed) created by catch
- Status changed to RTBC
8 months ago 1:57pm 19 August 2024 - 🇺🇸United States smustgrave
As mentioned probably hard to see without it being live. But idea of starting as soon as phpcs is done makes sense. And probably be very welcome as I've seen code that probably works but never ran because a spacing issue or something small.
- 🇫🇷France nod_ Lille
Let's see how it goes
Committed and pushed c1463afbf7 to 11.x and 7ca814c420 to 11.0.x and b74565b08b to 10.4.x and 4a46235f62 to 10.3.x. Thanks!
- Status changed to Fixed
8 months ago 8:38am 20 August 2024 - Status changed to Needs work
8 months ago 2:45am 21 August 2024 - 🇬🇧United Kingdom catch
This broke the performance test pipeline. I think we could probably fix it by moving the performance pipeline into the main .gitlabci.yml, but reverting for now.