- Issue created by @mfb
- First commit to issue fork.
- Status changed to Needs review
4 months ago 8:10pm 16 August 2024 - πΊπΈUnited States andileco
Thanks for catching this, @mfb. How does this patch look?
- πΊπΈUnited States mfb San Francisco
Didn't actually test it to confirm, but LGTM (might be nice to add some test coverage for the config form)
-
andileco β
committed dadd32c4 on 5.1.x
Issue #3468607 by andileco, mfb: ArgumentCountError at admin/config/...
-
andileco β
committed dadd32c4 on 5.1.x
- Status changed to Active
4 months ago 10:39pm 16 August 2024 - πΊπΈUnited States andileco
I committed the MR to dev so that people can use that, but I'm keeping the ticket open. If you have time and interest in writing a test, that would be very much appreciated!
- πΊπΈUnited States mfb San Francisco
Not sure if i will have time (as I'm not using this module at the moment) to help, but I'll go ahead and tag this for future reference
- π«π·France johnatas
Hi,
Iβve tested the code from the Merge Request as a patch on version 5.1.0, and it works like a charm on Drupal 11.0.6 and 11.0.7.
Thanks for the work!
- π΅π±Poland bronismateusz
I can confirm that the version
5.1.x-dev
, compared to5.1.0
works without any problem. - πΊπΈUnited States andileco
I'm going to apply this for the 5.0.x branch as well. It's just remaining open because @mfb suggested some tests.
-
andileco β
committed 650d8687 on 5.0.x
Issue #3468607 by andileco, mfb, johnatas, bronismateusz:...
-
andileco β
committed 650d8687 on 5.0.x