Speed up JSON:API ResourceTestBase

Adding related issue.

Down to a couple of test failures but they don't really make sense to me, so going to pause here for a bit.

I'm getting similar failures in 📌 Convert IpAddressBlockingTest to a Unit and Kernel test and improve Fixed ... I think HEAD is broken

Fixed the test failures in the subclasses - all small changes in the end. Obviously there's a lot of variation between test runs anyway but it definitely saves time:

Before:

Drupal\Tests\jsonapi\Functional\CommentTest                   11 passes  171s 

(although I've seen this take more than 180s on other test runs)

After

CommentTest Drupal\Tests\jsonapi\Functional\CommentTest                    9 passes  162s

Combined with Alex's multiple module install issue, it goes down to:

rupal\Tests\jsonapi\Functional\CommentTest                    9 passes  153s

We can assume most of the other tests based on ResourceTestBase will also be reduced by 5-20 seconds each, so should result in overall minutes of compute time reduced given there are 55 tests using ResourceTestBase.

Reviewed the changes, net code is effectively the same. These tests run for a lot of entity types, this could be quite the save.

I did do a 180 when i saw the changes to testPostIndividual since it seemed the skipped part was removed. Technically it is, but the todo is kept. I understand that we can't keep the markTestSkipped, since that would kinda undo part of the optimisation, just a little sad that is is no longer visible in the suite that the post test for files is skipped.

I'm all for the optimisations, thanks catch. Keep on keeping on.

I think all the doTest… methods should be protected per the previous optimisation patches.

Good point - made that change.

nod_ → closed merge request !9220

Committed and pushed ae9641c117 to 11.x and 8415927305 to 11.0.x and 9048455c90 to 10.4.x and 1a870a2555 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.