- Issue created by @f.mazeikis
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks for creating this, @f.mazeikis!
This is an oversight/oversimplification I introduced in 📌 Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed : I assumed we'd only need field storage settings, but as of 📌 Introduce `hook_storable_prop_shape_alter()`, use it to prefer the Media Library widget for "image" PropShape if Media Library is installed Fixed , we actually also need field instance settings.
- Merge request !168#3467712: Add fieldInstanceSettings to `(Candidate)StorablePropShape` + `StaticPropSource` → (Merged) created by Unnamed author
- Issue was unassigned.
- Status changed to RTBC
3 months ago 11:56am 14 August 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks, @f.mazeikis — you were 99% there!
I only had to fix 1 bug and 1 oversight to get this to green:
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...You'll be unblocked on 📌 Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria Fixed in a few minutes 😊
-
Wim Leers →
committed d248eff2 on 0.x authored by
f.mazeikis →
Issue #3467712 by f.mazeikis, Wim Leers: Follow-up for #3461499: Add...
-
Wim Leers →
committed d248eff2 on 0.x authored by
f.mazeikis →
- Status changed to Fixed
3 months ago 12:10pm 14 August 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Automatically closed - issue fixed for 2 weeks with no activity.