Follow-up for #3467712: field instance settings lost in ComponentPropsForm

Created on 22 August 2024, 4 months ago

Updated 5 September 2024, 4 months ago

Overview

@bnjmnm reported this over at #3462310-32: Component props form: map textarea, bool, and select elements to React components → , second bullet:

For the enum/select, the select options are not making it to $form array, formTemporaryRemoveThisExclamationExclamationExclamation provides a select widget with only none as an option even though the all-props component has options. I'm sure I can get that fixed but wanted to first check if anyone here would immediately know where to go before I start digging.

Proposed resolution

This is a regression caused by 📌 Add fieldInstanceSettings to (Candidate)StorablePropShape Active .

I posted a fix over at #3462310-34: Component props form: map textarea, bool, and select elements to React components → .

This should land without test coverage for now because:

this can then unblock front-end work immediately
this is something that merits generic test coverage: that every prop in the sdc_test_all_props:all-props component has a functioning widget, that does live-update the preview. That's the scope of 🌱 [META] Redux sync on ALL prop types, not just ones with a single [value] property Active .

User interface changes

The <select> has options again!

🐛 Bug report

Status

Fixed

Component

Page builder

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

blocker

Merge Requests

!198Follow-up for #3467712: field instance settings lost in ComponentPropsForm
Merged
🇧🇪Belgium wim leers
updated 4 months ago

Comments & Activities

Issue created by @wim leers
Merge request !198#3469729: Follow-up for #3467712: field instance settings lost in ComponentPropsForm → (Merged) created by wim leers
Issue was unassigned.
Status changed to RTBC 4 months ago2:23pm 22 August 2024
Comment 4 months ago →
🇺🇸United States bnjmnm Ann Arbor, MI
Wim Leers → credited bnjmnm → .
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Pipeline finished with Skipped
4 months ago
#261674
Comment 4 months ago →
System Message

Wim Leers → committed 20d3a635 on 0.x
Issue #3469729 by Wim Leers, bnjmnm: Follow-up for #3467712: field...
Status changed to Fixed 4 months ago2:25pm 22 August 2024
Comment 4 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024