[2.0.0-beta2] Layouts: Tests

christian.wiedemann → made their first commit to this issue’s fork.

Hi checked the tests right now. I think Mikael had everything implemented expect the field ui stuff? Am I right?

What do you think is missing? Just let me know

hello, i think yes, everything has been already done, especially in 📌 [2.0.0-beta3] Sources: Tests Active for example.

- Test deriver plugin : ok
- test rendering with field layout : modules/ui_patterns_layouts/tests/src/Functional/LayoutFieldFormatterRenderTest.php
- test rendering with layout builder : modules/ui_patterns_layouts/tests/src/Functional/LayoutBuilderFieldFormatterRenderTest.php
- tests form integration in layout builder : modules/ui_patterns_layouts/tests/src/Functional/LayoutBuilderRenderTest.php

hello, i think yes, everything has been already done, especially in 📌 [2.0.0-beta3] Sources: Tests Active for example.

- Test deriver plugin : ok
- test rendering with field layout : modules/ui_patterns_layouts/tests/src/Functional/LayoutFieldFormatterRenderTest.php
- test rendering with layout builder : modules/ui_patterns_layouts/tests/src/Functional/LayoutBuilderFieldFormatterRenderTest.php
- tests form integration in layout builder : modules/ui_patterns_layouts/tests/src/Functional/LayoutBuilderRenderTest.php

maybe what is missing is "Tests of possible integration ? iinside field layout display (and field layout form?)"
We should decide if we write a new test case for this or not.

I found two bugs with field layout. One I fixed with empty context for field_layouts. The rendering of forms inside a layout leads right now to empty slot because our Layout Component overwrites the build keys inside the region. This is also the reason why one test fails.

So should we support field_layout forms?

Hello Christian,
you set in review but the MR is not green ?
do i still need to review it?

1) Drupal\Tests\ui_patterns_layouts\Functional\FieldLayoutRenderTest::testRenderForm
Behat\Mink\Exception\ElementNotFoundException: Element matching css ".field--name-body" not found.
/builds/project/ui_patterns/vendor/behat/mink/src/WebAssert.php:465
/builds/project/ui_patterns/modules/ui_patterns_layouts/tests/src/Functional/FieldLayoutRenderTest.php:115

2) Drupal\Tests\ui_patterns_layouts\Functional\LayoutBuilderRenderTest::testRenderProps
Behat\Mink\Exception\ElementNotFoundException: Element matching css ".layout-builder-block" not found.
/builds/project/ui_patterns/vendor/behat/mink/src/WebAssert.php:465
/builds/project/ui_patterns/modules/ui_patterns_layouts/tests/src/Functional/LayoutBuilderRenderTest.php:78

The remaining problem is from $build[$region_name] = $regions[$region_name]; we did for Layout Builder integration, but may not work well with Field Layout.

We don't need to test with the Entity Form Displays because SDC is not compatible with the Form API yet, but Field Layout can also be used with Entity View Displays instead of Layout Builder.

i take it back to check and finish for merge

i added a few minor changes.
and removed the unwanted tests. please review Christian :)

Automatically closed - issue fixed for 2 weeks with no activity.