Drop core 10.2 support, make plugins use PHP attributes

Created on 12 August 2024, 4 months ago
Updated 27 August 2024, 4 months ago

Problem/Motivation

Affected plugins:

📌 Task
Status

Fixed

Version

1.0

Component

Other backend

Created by

🇵🇱Poland Graber

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Graber
  • Assigned to claudiu.cristea
  • 🇷🇴Romania claudiu.cristea Arad 🇷🇴

    I can work on this

  • Merge request !18Resolve #3467547 "Drop 10.2 support" → (Merged) created by claudiu.cristea
  • Pipeline finished with Success
    4 months ago
    Total: 196s
    #251701
  • Pipeline finished with Failed
    4 months ago
    Total: 156s
    #251722
  • Pipeline finished with Success
    4 months ago
    Total: 180s
    #251726
  • Pipeline finished with Success
    4 months ago
    Total: 177s
    #251780
  • Pipeline finished with Success
    4 months ago
    Total: 160s
    #251818
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • 🇷🇴Romania claudiu.cristea Arad 🇷🇴

    Done:

    • Bumped minimum Drupal version to 10.3
    • Configured GitLab CI to run tests in 3 scenarions:
      • PHP 8.1, Drupal 10.3
      • PHP 8.1, Drupal 10.4
      • PHP 8.3, Drupal 10.3
    • Converted annotations to attributes, where possible
    • Used autowiring and autoconfiguration (this should be extended in the future)
    • Updated dev instance https://github.com/graber-1/drupal_lms_ddev/pull/1
  • Pipeline finished with Success
    4 months ago
    Total: 162s
    #251829
  • Pipeline finished with Success
    4 months ago
    Total: 161s
    #251837
  • 🇵🇱Poland Graber

    Autowiring is interesting indeed, introducing it here is a step forward, not sure though if adding too many new things will not frighten other potential contributors.. Let's leave it with the most complex code that not many will decide to touch anyway, at least until it's used more widely in the contrib world.

  • 🇷🇴Romania claudiu.cristea Arad 🇷🇴

    Well, I think a simpler code is more appealing for contributors. Also, the module is still in very early stage, it could be a good place to learn to use the modern tools offered by Drupal >=10.3

  • 🇵🇱Poland Graber

    Sigh.. added some autowiring performance improvements with lazy instantiation. Looks like this is the way to go and there's no stopping it ;)

  • 🇷🇴Romania claudiu.cristea Arad 🇷🇴

    Looks good to me. It was just a start in regards of autowiring :)

  • Pipeline finished with Skipped
    4 months ago
    #252439
  • Status changed to Fixed 4 months ago
  • 🇬🇧United Kingdom catch

    Looked at this retrospectively: looks great to me, nice to get rid of so much boilerplate.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024