- Issue created by @Graber
- Assigned to claudiu.cristea
- Issue was unassigned.
- Status changed to Needs review
4 months ago 2:57pm 12 August 2024 - 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Done:
- Bumped minimum Drupal version to 10.3
- Configured GitLab CI to run tests in 3 scenarions:
-
- PHP 8.1, Drupal 10.3
- PHP 8.1, Drupal 10.4
- PHP 8.3, Drupal 10.3
- Converted annotations to attributes, where possible
- Used autowiring and autoconfiguration (this should be extended in the future)
- Updated dev instance https://github.com/graber-1/drupal_lms_ddev/pull/1
- 🇵🇱Poland Graber
Autowiring is interesting indeed, introducing it here is a step forward, not sure though if adding too many new things will not frighten other potential contributors.. Let's leave it with the most complex code that not many will decide to touch anyway, at least until it's used more widely in the contrib world.
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Well, I think a simpler code is more appealing for contributors. Also, the module is still in very early stage, it could be a good place to learn to use the modern tools offered by Drupal >=10.3
- 🇵🇱Poland Graber
Sigh.. added some autowiring performance improvements with lazy instantiation. Looks like this is the way to go and there's no stopping it ;)
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Looks good to me. It was just a start in regards of autowiring :)
-
graber →
committed 885da0a7 on 1.0.x authored by
claudiu.cristea →
Issue #3467547: Drop core 10.2 support, make plugins use PHP attributes
-
graber →
committed 885da0a7 on 1.0.x authored by
claudiu.cristea →
- Status changed to Fixed
4 months ago 7:45am 13 August 2024 - 🇬🇧United Kingdom catch
Looked at this retrospectively: looks great to me, nice to get rid of so much boilerplate.
Automatically closed - issue fixed for 2 weeks with no activity.