All links from module to the SEO Guide are broken

Created on 11 August 2024, 3 months ago
Updated 11 September 2024, 2 months ago

Problem/Motivation

The Drupal SEO guide on volacci.com has been removed, and now all links from the SEO guide, and thus the instruction/guidance have been removed as the links just send you to a blog filtered for Drupal posts.

Steps to reproduce

Click on the #seo_guide link from any checklist item (for example, https://www.volacci.com/drupal-seo-guide/clean-urls from the Enable Clean URLs checklist item) and verify you are redirected to https://www.volacci.com/blog-category/drupal

Proposed resolution

The content was published on volacci.com and therefore under their copyright. The best course of action would be to republish the content there.

If that is not an option, we could add the content, or newly written content, to the checklist item, to help text/documentation in the module, or to Drupal.org as documentation.

Remaining tasks

Get direction from the maintainers.

User interface changes

TBD

API changes

TBD

Data model changes

TBD

πŸ› Bug report
Status

Fixed

Version

5.2

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @thejimbirch
  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    Thanks, @thejimbirch. I'll surface this to @Ben Finklea.

  • Status changed to Postponed: needs info 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    @thejimbirch, I spoke to @Ben Finklea, and he says he doesn't work with Drupal much these days and offered to let me take over maintenance of the module. But I'm not a subject matter expert, whereas it looks like you specialize in SEO*. Would you be interested in taking the helm? You're obviously more than qualified to maintain such a simple module if it aligns with your business needs. I'm just keeping the lights on at this point. πŸ™‚

    * And theremins, huh? πŸ˜›

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    It’s true. I like your checklist API for sure. I maintain the launch_checklist module also. And have been known to play the rock theremin (not to be confused with people who actually know how to play songs in the theremin).

    Kudos to Ben. I hope he is doing well with his new ventures.

    I would be more than happy and honored to maintain this module with you.

  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    It’s true. I like your checklist API for sure.

    Thanks! πŸ˜„

    I would be more than happy and honored to maintain this module with you.

    Great! I've reached out to @Ben Finklea to give me full permissions and to discuss transitional details, like how to handle the fact that the module and the project page still link to his website. Obviously, we can't move this issue forward until we iron some of that out. I'll be in touch.

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    Makes sense, thanks!

  • Assigned to thejimbirch
  • Status changed to Active 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    @Ben Finklea has granted me permissions, and I've added you as a maintainer, @thejimbirch. He says to go ahead and remove all links to Volacci, so you may proceed accordingly. Pretty much everything you'll need is in seo_checklist.module, templates/seo-checklist-getting-started.html.twig, and seo_checklist.js. I'll review an MR when you're ready. Ask me if you have any questions.

  • Merge request !9Resolve #3467422 "Remove broken links" β†’ (Merged) created by thejimbirch
  • Issue was unassigned.
  • Status changed to Needs review 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    I believe I removed all unneeded links. PHPcs and stan passing. Created a follow up for ESlint errors.

    Needs testing/validation that all is well.

  • Assigned to thejimbirch
  • Status changed to Needs work 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    Looks like it's almost there. We've just got a PHP warning to fix:

    Warning: Undefined array key "render element" in Drupal\Core\Theme\ThemeManager->render() (line 202 of core/lib/Drupal/Core/Theme/ThemeManager.php).
  • Status changed to Needs review 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    Removed Getting Started and Be Efficient sections. These sections can be replaced by a Tour and proper documentation, which we have issues for. I have the Tour started in Drupal CMS, but can move it here for all.

    Let's get folks into the checklist faster as it is very intuitive to use.

  • Status changed to RTBC 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States traviscarden

    I agree: "Getting Started" and "Be Efficient" are superfluous, the UI is basically self-explanatory, and there are better ways to help novice users. At some point, it might be good to add a simple hook_help() implementation. For now, I'm happy with this.

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts
  • Status changed to Fixed 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024