- Issue created by @berdir
- Status changed to Fixed
5 days ago 1:16pm 16 November 2024 - 🇦🇲Armenia murz Yerevan, Armenia
Thank you for the feedback! Was busy with other project and had no time to contribute to OpenTelemetry, but now got some time and improved some things:
1. In the issue ✨ Add support for open-telemetry/sdk v.1.1 and make missing dependencies exceptions more clear Active I improved error handling that should prevent the recursion, and clearly describes if the required libraries are missing - please test.
2. Implement covering by functional tests, which should prevent us from broken functionality and regressions on the new versions.
3. About this:
* In SigNoz, I saw each request twice, once with a (request) suffix, not if that's on purpose but seems to add little.
- it's the intended behavior, because Drupal actually starts processing the request later, and spending some time on the initialization of the Drupal Kernel and so on, so it's good to see the full image of what is happening under the hood. Maybe I'll add an option to disable this, will think about it.
4. About this:
* Trace stuff could maybe use percentage settings, e.g. detailed traces for database and future stuff only on 1% of the requests, similar to how blackfire and other APM's operate.
Yes, I have this feature in the roadmap, filled a separate issue about this: ✨ Add the OpenTelemetry Sampler and the sampling rate configuration Active
For now, probably you can already control this using the env variables like this:export OTEL_TRACES_SAMPLER="traceidratio" export OTEL_TRACES_SAMPLER_ARG="0.5"
- more details here: https://opentelemetry.io/docs/languages/sdk-configuration/general/
But I will test this more later.
So, I hope that covered all your points, let's close this issue and feel free to fill separate issues about each bug and feature request - it will be easier to track them separately.