- Issue created by @jessebaker
- Assigned to wim leers
- Status changed to Needs review
5 months ago 1:30pm 9 August 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
@jessebaker marked the MR as ready, I'm assuming that means this needs review.
P.S.: Next time, please mark the issue as needing review π
- Assigned to jessebaker
- Status changed to Needs work
5 months ago 1:34pm 9 August 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The branch is called
csstidyup
, but the issue title is "general tidy up". Can we update the issue title to be a bit more precise? πI'm surprised this is passing tests, because
.findByText()
does not seem to be used correctly and we're not updatingui/package.json
despite importing something new?After that's addressed, please assign this to @bnjmnm for review β the change in the
.module
file needs his sign-off. - Assigned to bnjmnm
- Status changed to Needs review
5 months ago 2:18pm 9 August 2024 - Assigned to hooroomoo
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Actually β¦ @bnjmnm is out today, but I'm pretty sure @hooroomoo knows enough about the JSX theme engine stuff to be able to review that one change in the
.module
file π€ - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π π β my bad, sorry!
- Issue was unassigned.
- Assigned to jessebaker
- Status changed to Needs work
5 months ago 9:15am 12 August 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
@jessebaker: can you address @hooroomoo's https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...? π
After that, please assign this to @bnjmnm, he should confirm my theoretical answer to @hooroomoo's excellent review question.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π One last round of feedback from me, trying to catch everything that @bnjmnm might ask.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Nice to see this happening. I had a suggestion for applying the formatting more broadly to the tests, and once that is OK I'll probably click approve.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Didn't know @bnjmnm wrote
experience_builder_preprocess_form_element()
, so then this is definitely ready to go as far as I'm concerned π π’ - Status changed to RTBC
5 months ago 8:29am 13 August 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I meant to mark this RTBC in #15 π π
P.S.: I think it might be easier to first land π Document Cypress test best practices (especially how to write reliable tests) Needs review β that touches the Cypress tests in a much bigger way, and this issue's MR will likely conflict, but is mostly doing trivial whitespace reformatting β¦ which is easier to redo. So, @jessebaker, I suggest you land that issue first and then land this one π€
- Assigned to bnjmnm
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Needs final sign-off from either @bnjmnm or @hooroomoo, assigning to @bnjmnm since he already reviewed it previously.
- First commit to issue fork.
-
bnjmnm β
committed 4d862ef1 on 0.x authored by
jessebaker β
Issue #3466678 by jessebaker, bnjmnm, Wim Leers, hooroomoo: General tidy...
-
bnjmnm β
committed 4d862ef1 on 0.x authored by
jessebaker β
- Issue was unassigned.
- Status changed to Fixed
5 months ago 1:48pm 13 August 2024 - πΊπΈUnited States bnjmnm Ann Arbor, MI
Good call on doing a round of cleanup when it's still a manageable scope.
Automatically closed - issue fixed for 2 weeks with no activity.