- Issue created by @thomas.frobieter
I tested this with a node and works fine, I'll check with a taxonomy term and let you know
- Status changed to Closed: works as designed
5 months ago 9:04am 15 August 2024 Yes, I understand this. But the thing is, if you have, for example, a Drupal view showing some Nodes as Cards, you will have an unnecessary wrapper around the cards.
So we have to add further custom CSS / classes to the node wrapper to have equal-height cards.
Example: https://codepen.io/thomas-frobieter/pen/dyBJGRx?editors=1100
So this solution produces more and deeper markup structures.
But I am fine with overriding the SDC myselfโnot a big deal!
Added a new Taxonomy component as well.
Nice :)
- Status changed to Needs work
5 months ago 9:58am 15 August 2024 Totally agree and you have a good point, IMO we can add an optional prefix and suffix and contextual classes to the card but yet again this could be the case for many other components as well
Could you do me a favor and open a PR for that?
- Assigned to thomas.frobieter
- Issue was unassigned.
- Status changed to Needs review
5 months ago 10:55am 20 August 2024 Done, please take a look.
As long as we don't add a specific "contextual_links"-property, I think we should simply use card_utility_classes to add the "contextual-region" class? Seems good enough for me.
For the prefix and suffix attributes, I took a look at the default node template: https://api.drupal.org/api/drupal/core%21modules%21node%21templates%21node.html.twig/11.x
I think the best way is to just "copy" this definition to the components?
I am currently unable to create an MR, not sure what's the problem - so please see: https://git.drupalcode.org/issue/radix-3466513/-/compare/6.0.x...3466513-contextual-links-are
-
doxigo โ
committed a59717a7 on 6.0.x authored by
thomas.frobieter โ
Issue #3466513 by thomas.frobieter, doxigo: Contextual links are missing...
-
doxigo โ
committed a59717a7 on 6.0.x authored by
thomas.frobieter โ
-
doxigo โ
committed 038a5fed on 6.0.x authored by
thomas.frobieter โ
Issue #3466513 by thomas.frobieter, doxigo: Contextual links are missing...
-
doxigo โ
committed 038a5fed on 6.0.x authored by
thomas.frobieter โ
- Status changed to Fixed
5 months ago 6:48am 27 August 2024 Looks solid Thomas, great work. I had to cherry-pick and UI wise I couldn't open a MR as well. Anyways, thanks a lot, merged.
Automatically closed - issue fixed for 2 weeks with no activity.