Release with Drupal 11 support

Created on 6 August 2024, 5 months ago
Updated 14 September 2024, 4 months ago

Drupal 11.0.0 is ready and we need to create release with Drupal 11 support

📌 Task
Status

Needs work

Version

2.0

Component

Code

Created by

ivnish Kazakhstan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ivnish
  • Assigned to Rajan Kumar@2026
  • 🇮🇳India Rajan Kumar@2026

    Hi @ ivnish

    I have fixed the issue with the Views Aggregator Plus module in Drupal 11 and created a patch. Please see the attached screenshot for reference. Thanks.

  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • Status changed to Needs work 5 months ago
  • 🇺🇸United States tr Cascadia

    You patch will not work. For example, this:

    -        "drupal/core": "^9.2 || ^10"
    +        "drupal/core": "^9.2 || ^10 || ^11"

    directly conflicts with:

    -    return is_array($rendered_value) ? $this->getRenderer()->renderPlain($rendered_value) : $rendered_value;
    +    return is_array($rendered_value) ? $this->getRenderer()->renderInIsolation($rendered_value) : $rendered_value;

    because renderInIsolation() DOES NOT EXIST in versions of Drupal less than 10.3.

    Porting to a new version requires a lot more care than just making error message disappear in the new version. All changes have to be made in a way that does not break this module for existing sites.

    In general, supporting a new major version of Drupal core will require a new version of this module so that support for old unsupported versions of core can be dropped and so we won't require a lot of conditional code for things that changed between versions.

    It may be that very few changes are needed, but whatever they are they need to be made carefully and with testing to ensure we're not breaking existing sites. I have not started the process yet for this module so I can't say exactly what it will entail, but I would almost certainly want to create a new 2.1.x branch for anything new required by D11 support.

  • 🇺🇸United States tr Cascadia

    Oh, also, there's an issue already open for this - 📌 Automated Drupal 11 compatibility fixes for views_aggregator Needs review . Why did you open a new issue instead of posting there?

  • ivnish Kazakhstan

    Because "commit drupal 11 support code" != "create new release". More than 7,240 sites are waiting new release, because views_aggregator is blocking upgrade to Drupal 11.

    You can close this issue if it offends you

  • 🇺🇸United States tr Cascadia

    A D11 release will be made when the module is known to work in D11.
    Specifically, everything except 📌 Fix PHP 8 / Drupal 10 test failures Needs review has now been addressed, so that's blocking a release.
    You can use 2.1.x-dev until then if you really need to use this in D11 now.

  • 🇺🇸United States tr Cascadia

    2.1.0 is now released with D11 support.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024