- Issue created by @Kristen Pol
Not 100% sure if
{% include '@base/grid/grid.twig' with { items: [column_one, column_two, column_three], column_class: 'col-xxs-12 col-l-4', row_class: 'row--equal-heights-content row--vertically-spaced', } only %}
should be represented in the yml in any way. But if it shouldn't then the attached yml should work I think.
Should the twig be updated like this to include the slot info in the comment?:
{# /** * @file * Starshot three column component. * * Variables: * - column_one: [string] First column. * - column_two: [string] Second column. * - column_three: [string] Third column. */ #} {% set column_one %} {% block column_one %} {% endblock %} {% endset %} {% set column_two %} {% block column_two %} {% endblock %} {% endset %} {% set column_three %} {% block column_three %} {% endblock %} {% endset %} {% include '@base/grid/grid.twig' with { items: [column_one, column_two, column_three], column_class: 'col-xxs-12 col-l-4', row_class: 'row--equal-heights-content row--vertically-spaced', } only %}
- Status changed to Needs work
about 1 month ago 12:03am 6 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Shouldn't the say "slot"? Not sure how the parser is determining that... haven't looked at the code yet.
You're right it should be more like this:
{# /** * @file * Starshot three column component. * * Variables: * - column_one: [string] First column slot. * - column_two: [string] Second column slot. * - column_three: [string] Third column slot. */ #}
or this:
{# /** * @file * Starshot three column component. * * Variables: * - column_one: [string] Column slot. * - column_two: [string] Column slot. * - column_three: [string] Column slot. */ #}
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I used the first one:
https://git.drupalcode.org/project/demo_design_system/-/commit/725027a11...
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Use the new merge request guide:
https://www.drupal.org/community-initiatives/starshot-demo-design-system... β
- Assigned to Kristen Pol
- Status changed to Postponed
about 1 month ago 5:14pm 7 August 2024 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Marking postponed until the script changes have been reviewed π Create automated script for converting components to SDC Fixed .
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Closing as fixed because we'll do the YAML updates here:
π Use SDC conversion script to create baseline SDC YAML and README files Fixed
- Issue was unassigned.
- Status changed to Fixed
about 1 month ago 10:08pm 9 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.