Double 'select all' checkbox on /admin/modules/update

Hi, I have tried to follow the steps mentioned above but did not encounter any issues. Could you please provide the steps to reproduce the issue?

Thankyou !!

I was also not able to reproduce this. Please add steps how to reproduce and most importantly (like always) which Drupal version is affected. You might want to test if it works with the latest dev build and if any module might potentially be involved here.

Cheers!

OK, thanks for having a go.

I am at a loss - I have installed a Drupal 10, wiped out pretty much every module that I possible can and yet still I am seeing the same behaviour.

It is as though something is inserting the extra checkbox evidenced (maybe) by the slight delay in its appearance after a cache clear and refresh…

Just for good measure, here is the entire enabled module list just so to redue the suggestion that some other module might be causing this....

Block
Block Content
Breakpoint
CKEditor 5
Custom Menu Links
Database Logging
Datetime
Field
Field Ul
File
Filter
Gin Toolbar
Image
Link
Menu Ul
MySQL
Node
Options
Path
Standard
Taxonomy
Text
Text Editor
Token
Toolbar
Update Manager
Views
Views Ul

System

Drupal 10.3.1
Apache/2.4.33 (Win64) OpenSSL/1.0.2u mod_fcgid/2.3.9 PHP/8.3.1
PHP 8.3.7, memory limit: 256M
MySQL 5.7.24
PHP Caching module: OpCache
Web browser: Version 127.0.6533.89 (Official Build) (64-bit)
Front end theme: Claro
Backed theme: Gin

I can confirm the issue, D 10.3.1 and drupal/gin 3.0.0-rc13.

I believe is caused by this file table.html.twig https://git.drupalcode.org/project/gin/-/blob/8.x-3.0-rc13/templates/dat... If we remove this condition works fine. Was added in this commit https://git.drupalcode.org/project/gin/-/commit/81bc62b43be993b8d22b6a4f... / issue https://www.drupal.org/project/gin/issues/3460111 🐛 Save button missing in modal for editing using the Front End Editing module Needs work .

I'm trying to understand why this code was added, and if we remove it it can't cause another problem.

This will certainly break those instances where this code is needed.

I can confirm the issue, D 10.3.1 and drupal/gin 3.0.0-rc13.

I still can't reproduce this issue on any site or test instance I run, also not on a box fresh instance of 10.3.2 with latest Gin 3.0-dev (see also below for a test instance). So there might be a module interfere here potentially.

Box-fresh Drupal 10.3.2 instance: https://master-dqbj11ohgbwsnu33tcvtupgigjyeqg5i.tugboatqa.com/admin/modu... (admin/admin)

Hi!

Also same issue in admin/reports/updates/update and also in admin/reports/upgrade-status pages, to see if others also experience the error there.
I thought https://www.drupal.org/project/gin/issues/3460194 🐛 Double check-all checkboxes in sticky header Fixed could provide a fix but it is not the case for me, so changed to 'active' in order to dig more

Best

A little bit more of info in my case: D@10.3.2 and gin@RC13
I can see the issue in both pages mentioned above (one from core, one on the upgrade_status module)

If i inspect the HTML from the page, it seems no other templates apart from core, gin or claro are used

The piece of code that seems to be duplicated comes from https://www.drupal.org/project/gin/issues/3458191 🐛 [webform] The table width does not fill the screen Fixed (MR diff)

in my case, on the page of the upgrade_status module, i can see the following code is rendered:

<th class="select-all gin--sticky-bulk-select">
  <input type="checkbox" class="form-checkbox form-boolean form-boolean--type-checkbox" title="Select all rows in this table">
  <input type="checkbox" class="form-checkbox form-boolean form-boolean--type-checkbox" title="Select all rows in this table">
</th>

and if we take a look at templates/dataset/table.html.twig (L66 onwards):

  <{{ cell.tag }}{{ cell.attributes.addClass(cell_classes) }}>
    {{- cell.content -}}
    {% if 'gin--sticky-bulk-select' in cell_classes %}
      <input
        type="checkbox"
        class="form-checkbox form-boolean form-boolean--type-checkbox bar"
        title="{{ 'Select all rows in this table'|t }}"
      />
    {% endif %}
  </{{ cell.tag }}>

the additional input is the second one rendered in the table (i think in this case, the original cell.content already contains the 'select all' and then it is rendered a second time making hte duplication

I have checked other sites i have, and same issue appears in the others, same piece of code

Hope it helps

I'm also seeing this on several websites.

It's also showing on Webforms. See for example the screenshot of a remote post handler.

We see the same on the "translations" view when using the TGMGT module.
Looks like the issue has already been resolved in 🐛 Double check-all checkboxes in sticky header Fixed ; when I applied its MR changes, the error was gone.

Can you all test if this is still a problem with the latest dev release? If not we'll close this out as it will be fixed with the next release.

Thanks!

Hi @saschaeggi

Latest dev release fixes this, i dont see the double checkbox where i had this.

   $ composer require 'drupal/gin:3.x-dev@dev'
   
   - Upgrading drupal/gin (3.0.0-rc13 => dev-3.x 13b5936)

Thanks for having a look. Closing this as duplicate of 🐛 Double check-all checkboxes in sticky header Fixed