[2.0.0-beta1] ui_patterns_element_info_alter() implementation overrides allowed formats for all text_format elements

Fixed some typos in the issue description ;)

Thanks a lot Tom for using an early version of UI Patterns 2.x and helping us making the module ready for beta.

Additionally the code of WysiwygWidget::textFormat looks quite outdated and e.g. names Drupal\filter\Element\TextFormat::processTextFormat() which does not exist anymore (it is TextFormat::processFormat() now and has a lot more code to allow limiting formats).

Indeed. It was not caught by our quality tools because it was in a comment.

The ui_patterns_element_info_alter() implementation adds the WysiwygWidget::textFormat #pre_render callback for all text_format elements. Unfortunately this breaks core's functionality to limit a text fields available text formats. In my case, there is only Full HTML allowed, but with ui_patterns module installed, the text format selection is visible again and also allows to select Plain text.

@just_like_good_vibes can you have a look? It seems this is the follow-up of 🐛 [2.0.0-alpha3] WysiwygWidget bug with one text format Fixed

Hello, yes i will take the issue. Thank you for reporting the bug hctom.
i will try to fix this very soon.

You're welcome - I'm currently evaluating the state of ui_patterns and I am quite impressed so far! ;) Thanks a lot and keep up the good work.

thank you for your nice comment :)
i have posted a fix, please review.

The reason why. we use pre-render, is that we override the default behavior proposed by the form element to always propose the option "Plain text" and to allow all site-wide text formats.
Maybe we could renovate that in the future and simplify.

please review if you have some time to do it

Thanks for your fast response and fix. This looks good to me. In my node forms etc. the Text format select element is gone again, when only a single text format is allowed and the Wysiwyg source still has the Text format select element available.

I'd also say moving the #pre_render callback assignement to the actual source plugin is definitely better, so that code does not run for all text_format elements.

Thanks a lot again and: RTBC from my side ;)

thanks for the quick review. Indeed this was clearly a bug the way it was coded.

And yes we keep the select list in the Wysiwyg source form, even if only one format is available.
And we actually have two possible selections with the "Plain text" :)