Deprecate and / or remove unused Controllers and routes from WebAssert tests

Run the PHPUnit testing for the MR. I got 2 errors in the local testing. Below are the errors.

There were 2 errors:

1) Drupal\Tests\system\Functional\Routing\RouterTest::testFinishResponseSubscriber
TypeError: strcasecmp(): Argument #1 ($string1) must be of type string, null given

/var/www/html/core/modules/system/tests/src/Functional/Routing/RouterTest.php:52

2) Drupal\Tests\system\Functional\Session\SessionHttpsTest::testHttpsSession
Error: Call to a member function getSecure() on null

/var/www/html/core/modules/system/tests/src/Functional/Session/SessionHttpsTest.php:208
/var/www/html/core/modules/system/tests/src/Functional/Session/SessionHttpsTest.php:76

Not moving the status, will do check again and confirm.

What steps did you take to run those tests? The tests are not failing in gitlab so I'm guessing you have are testing something unrelated.

I'm getting the same errors in my local environment with HEAD (11.x) as well as this branch, so it is unlikely to be related. Setting back to NR.

Removals didn't seem to cause failures so going to mark.

Do we know if this is all of them? e.g. do tests fail if any of the other controllers are removed?

I did go through all the routes for this controller and found several usages in other tests, so I'm fairly confident we've covered all we should.

OK great, just couldn't tell whether that step had been done.

Committed/pushed to 11.x, thanks!

catch → closed merge request !9092

Automatically closed - issue fixed for 2 weeks with no activity.