- Issue created by @mondrake
- Status changed to Needs review
7 months ago 2:07pm 6 September 2024 - Status changed to RTBC
7 months ago 5:17pm 6 September 2024 - Status changed to Needs review
7 months ago 5:58pm 6 September 2024 - 🇮🇹Italy mondrake 🇮🇹
Thanks. Looking back, I am uncertain about one thing, see inline. Set back to NR.
- 🇬🇧United Kingdom jonathan1055
Pleased it worked. I suggested removing the condition
$CI_PIPELINE_SOURCE == "parent_pipeline"
, but just want to make sure that is the right thing. Should it check a different value? Do we need to make any distinction between scheduled pipelines and MRs and merge commits? It might be fine as is, but just wanted to ask the question. The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States smustgrave
believe feedback from #7 has been addressed, if I'm wrong please correct me
- 🇮🇹Italy mondrake 🇮🇹
I want to explore an alternative approach here, i.e. split the Test stage between unit tests and db-dependent tests. Let’s hold this for a bit longer.
- Status changed to Needs work
27 days ago 5:58pm 10 March 2025