Call to a member function getCurrencyCode() on null

This code at line 28ff does the job for me:

if($this->getAmount() != NULL){
      $amount = $this->getAmount();
      if ($amount->getCurrencyCode() != $shipment->getAmount()->getCurrencyCode()) {
        return;
      }
    }else{
      $amount = $shipment->getAmount();
    };

Hi @Umac_de,
I have added the code as requested. Please refer to the attached patch.
Thank you.

This bug is weird...
The parent class already calls appliesToShipment() prior to calling the applyToShipment() method.

protected function appliesToShipment(ShipmentInterface $shipment) {
    if (!$shipment->getShippingMethodId() || !$shipment->getAmount()) {
      // The shipment is still incomplete, skip it.
      return FALSE;
    }

And it returns false if !$shipment->getAmount() is NULL.

So based on comment #4 and the backtrace, the problem seems to be due to the amount that isn't set on the promotion offer. That is not possible from the UI as the field is required which seems to indicate your promotion is malformed, so this isn't something that should be solved with a patch.

Are you creating promotions programatically? If that is the case, you should revise the code to properly set the amount offer. Closing this as won't fix.

Attaching a screenshot of the admin UI so you can see that the promotion can't be saved if the amount isn't filled:

So once again a data problem to me.

@ jsacksick

No, I am not creating promotions programatically, but, you are right, the amount is missing on the config site.

Don't know how that happened.
Thank you!

@Umac_de: weird... I believe this is a better fix, as fixing the promotion offer code just turns this bug into a silent one... Better to fix a malformed promotion that probably shouldn't be active anymore than having it silently fail IMO.