- Issue created by @rkoller
- First commit to issue fork.
- ๐ฎ๐ณIndia libbna New Delhi, India
Hi @rkoller we have a search icon on the right side of input field, we can make that a submit button and disable the auto searching functionality. Needs your input on this!
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
Thanks for the MR @libbna! i've tested the change and functionally wise it looks good to go from my perspective. I've also checked if the touch targets are meeting the minimum requirements for the clear and submit button - and the do. i've only left a comment in regards of the button label. and someone else would have to review the changes on the code level, something i am unable to provide input on. but i'll set the issue back to needs work for the button label and for the failing tests.
- ๐ฎ๐ณIndia libbna New Delhi, India
Thank you @rkoller for the review. I have updated the button label and class name as you've suggested.
- Status changed to Needs work
4 months ago 6:31am 8 November 2024 - First commit to issue fork.
Fixed the failing nightwatch tests and merged the latest changes from 2.0.x.The failing test is not related to the changes in the MR , so marking it NR.
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
Only one small comment on the MR - we don't need to debounce any more since we're not responding on keyup events.
- ๐บ๐ธUnited States pfrilling Minster, OH
The code looks good to me. All the MR feedback looks to have been addressed.
-
chrisfromredfin โ
committed 0597c082 on 2.0.x authored by
libbna โ
Issue #3464794 by utkarsh_33, libbna, chrisfromredfin, rkoller,...
-
chrisfromredfin โ
committed 0597c082 on 2.0.x authored by
libbna โ
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
Reviewed, manually tested, rebased, tests are passing (after a re-test of ye ole flaky testMultiplePlugins)... good to go!
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
thank you! i'Ve just realized right now how many issues when testing stemmed from project browser immediately querying the d.o servers after a second or two of not typing. now requiring the press or click of the return key make things way more controllable and also less overwhelming.
Automatically closed - issue fixed for 2 weeks with no activity.