- Issue created by @Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Okay the reason seems to be that in
Drupal.dialog(document.getElementById('drupal-off-canvas')).close();
the
document.getElementById('drupal-off-canvas')
part returns null.Because
#drupal-off-canvas
id is missing on the off canvas element!But even in 11.x it still seems to be present, so must be something specific to the project or homebox!
https://git.drupalcode.org/search?group_id=2&nav_source=navbar&page=3&pr... - Assigned to thomas.frobieter
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter we'll need to take a look tomorrow, the functionality is entirely broken due to this.
- Assigned to Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Okay this is definitely an incompatibility with Drupal 10.3.x! Downgrading to 10.2.5 brings functionality (and ID) back!
The ID was never existing, the close call seems to have worked without an ID before Drupal 10.3.x.
We'll simply remove the line with the
close()
call, as the page will reload anyway. If we'll ever need it again, we should simply add our custom ID on the dialog wrapper, as it never had the#drupal-off-canvas
ID, not even in 10.2.5 where it was working.Removed the affected line as the page reloads anyway after adding a portlet.
- Issue was unassigned.
- Status changed to Fixed
9 months ago 7:28am 31 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.