Certain filters should only be shown if they are actually defined

kunal.sachdev → made their first commit to this issue’s fork.

This looks really good to me. I'm honestly pretty low on complaints, but there a few small things that could be improved here. Can't wait to RTBC!

The changes are working really well.

However, I found 1 other issue for which I was going to file a new issue but I thought that seemed mostly related to this and perhaps could be handled in this issue itself.

In case of the "Recipes" source we do not have the Categories as well so in the case "Filter by category" filter is appearing with empty dropdown and which is of no use and gives bad UX/DX.

Not sure whether we want to reload the page on tab change @phenaproxima please suggest.

Tested with all the 3 sources and seems working as expected, only those filters are displayed per source that is available or relevant.

The branch needs a rebase.

Seems pretty much correct to me! A few points of feedback and then we can continue on to the next step...

I see nothing to complain about in this MR. Granted, I wrote part of it, so I don't know if I want to RTBC, but consider this a soft RTBC if tests pass. I'd ideally like a Svelte expert (@bnjmnm would be my first choice) to give it a look, just to see if there are any major problems I wouldn't have noticed, since I don't know Svelte that well. But as far as I can tell, the changes make sense.

Svelte part looks solid and this is a nice step towards the presentation layer not making decisions about what a source does.

Manual testing - if I choose a filter (say, the "Access Control" category), it works and I get results. Recipes tab still shows 28 results. Then I click over to the Recipes and it shows 0 after a flash. And there are no filters to get my way out of it. If I go back to the Drupal.org tab and clear the filter, then back to recipes, it works and shows all the recipes.

Perhaps we're not clearing the stores between tab switches?

If categories IS a valid filter for recipes, but we're just not seeing it, then that's perhaps the issue (not showing a filter that it should?).

On subsequent loads it behaves a little better; it seems to be the first time you choose a filter.

@chrisfromredfin I have also experienced this bug sometimes while working with PB but I think this is not related to the current issue and for this, we can create a separate issue.

Thank you!

Yes, this issue is pre-existing. Create a separate issue for this 🐛 The functionality of showing results behaves abnormally on tab switch sometimes Active

If the bug is confirmed pre-existing, then I think this can go back to RTBC.

Thanks, Kunal, for opening the related issue!

was still in RTBC for some reason. moving back to fixed.

Automatically closed - issue fixed for 2 weeks with no activity.