Fix cspell, phpcs and phpstan

Created on 27 July 2024, about 1 month ago
Updated 10 August 2024, 29 days ago

Problem/Motivation

See https://git.drupalcode.org/project/glossify/-/pipelines/234947

Fix cspell, phpcs and phpstan please. As MR.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Anybody
  • Merge request !23Resolve #3464126 "Fix cspell phpcs phpstan" → (Merged) created by Anybody
  • Status changed to Needs work about 1 month ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Finally we need some dependency injection in GlossifyBase:

     ------ ---------------------------------------------------------------------- 
      Line   src/GlossifyBase.php                                                  
     ------ ---------------------------------------------------------------------- 
      76     \Drupal calls should be avoided in classes, use dependency injection  
             instead                                                               
      242    \Drupal calls should be avoided in classes, use dependency injection  
             instead                                                               
      249    \Drupal calls should be avoided in classes, use dependency injection  
             instead                                                               
      256    \Drupal calls should be avoided in classes, use dependency injection  
             instead                                                               
     ------ ----------------------------------------------------------------------
    
  • Status changed to Needs review about 1 month ago
  • 🇩🇪Germany Anybody Porta Westfalica

    MR!18 from 📌 Fix phpstan Fixed already solves dependency injection, let's use that one!

  • 🇩🇪Germany Anybody Porta Westfalica

    Nice, we're all green now! :)

    FYI: 𒀆𒀇𒀈𒀈𒀊𒀋 didn't work just in the .cspell-project-words.txt so I had to disable cspell for the test words area.

  • Pipeline finished with Skipped
    about 1 month ago
    #235648
    • Anybody committed 06a63eac on 3.x
      Issue #3464126 by Anybody: Fix cspell, phpcs and phpstan
      
  • Status changed to Fixed about 1 month ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Merged the fixes into dev!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024