Remove or demote mock to test folder

Keeping the mock API available for tests sounds useful.

I've done a big refactoring + cleanup and most of the tests are passing as well as all the linting steps.

There are some tests still not passing, but most of them are green already. If somebody would be willing to help here that'd be great as my available time is limited. I can continue working on it, but it might be a few days until I get to it again.

Green tests all over!! I still want to do more clean up but this is a great milestone in this initial refactoring.

Following up on #5 (all tests green). I have cleaned up any code that was related to the initial drupalorg_mockapi and I have moved only the parts that were needed to the "tests" folder and renamed the plugin slightly.

I've tested via Drupalpod and things look good too. This is now ready for review. It's a big MR but it's a big cleanup, so it's expected.

Rebased from latest and trying to fix the nightwatch test.

All green after rebase. Back to needs review.

I tried to test it when this Mock source was enabled. It does not get completely removed, Only the source name got removed.

Need a hook_update to delete the config value drupalorg_mockapi from the drupalorg_mockapi.

Yeah, this was a known issue that was discussed in the MR. Thanks for the commits @prashantc.
We also need to remove the tables. I named the hook "project_browser_update_9019" as suggested by Chris.

I added the above and also sorted out the missing hooks using "hook_update_last_removed".

Ready for review again.

If someone was a couple of versions behind and installs this, the runs "drush updb", they get the following:

In LegacyServiceInstantiator.php line 192:
                                                                                
  Class "Drupal\project_browser\Commands\UpdateFixtureCommands" does not exist

Should we retain a dummy version of this class for legacy updates? I'd guess it's not something we'd want to keep when we move to core, so I'd guess we need to evaluate whether it's worth keeping in play in the short time.

Where in the code does that class appear so it gets executed somehow by "drush updb"? I definitely wouldn't want to keep a dummy version of the file. We just need to figure out why is this triggered if there are no instances of it in the code anymore.

Hmmm, I was assuming it was coming from one of the _project_browser_populate_from_fixture() updates, but now I see they've all been removed, so I don't know what's causing this.

I’ll check this. Probably more cleanup needed somewhere.

@lostcarpark - there was still a file that needed to be removed. Done here: https://git.drupalcode.org/project/project_browser/-/merge_requests/554/...

Hopefully you won't get that warning anymore.

Error mentioned in #13 📌 Remove or demote mock to test folder Needs review was getting triggered from the drush.services.ymlfile.

The UpdateFixtureCommandsclass was removed therefore removed the drush file as well.

On comment #16 I wrote:

I’ll check this

And then we've done pretty much the same commit simultaneously.

@prashantc - I know that you're trying to help but it'd be great if we can coordinate on who's doing what. I'm happy if you want to take over but I just want to avoid duplicate efforts.

Aha! That seems to have done the trick. Update ran cleanly for me this time.

@prashantc - I know that you're trying to help but it'd be great if we could coordinate on who's doing what. I'm happy if you want to take over but I just want to avoid duplicate efforts.

@fjgarlin
Apologies and I agree to avoid duplicate efforts :), I encountered this error on cache clear as well, and then I found that the drush file is not required, unfortunately, we pushed the same change at the same time.

It's fine. I'm on slack as well if you need real time replies or checks.

Hopefully 🤞, this was the last change needed on this MR, but yeah, let's just make a quick comment or give a quick ping if something else comes up. Thanks for helping!

I've carried out manual testing including upgrading the module, uninstalling, and installing. Everything seems to be working as expected.

I also reviewed the code changes and they look good.

All tests have passed in CI.

I think this is good to go RTBC.

Woooo! big things are happening. :)

Automatically closed - issue fixed for 2 weeks with no activity.