- Issue created by @Wim Leers
- Merge request !128Resolve #3463986 "Preview componenttreehydrated" β (Merged) created by Wim Leers
- Assigned to tedbow
- Status changed to Needs review
about 1 month ago 12:58pm 31 July 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
@tedbow This should be a big accelerator to your work in π Introduce an example set of representative SDC components; transition from "component list" to "component tree" Fixed β this will make your work there be visible in the UI.
IOW: this is the subset of #3446722 that interacts with the client directly, and requires server-side code to be updated for the client to be usable.
Review suggestion: review only
ComponentTreeHydratedTest
. If that part makes sense to you, IMHO you can blindly approve this, because it'll represent a leap forward with strict test coverage. That would unblock you on #3446722, and is an important step towards finalizing the client's data model and the request/response flow. - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
I just realized that the MR's scope goes a bit further than the originally described/intended scope. Updated issue summary to explain why.
- First commit to issue fork.
-
tedbow β
committed c490a366 on 0.x authored by
Wim Leers β
Issue #3463986 by Wim Leers: Refactor SdcController::preview() to use...
-
tedbow β
committed c490a366 on 0.x authored by
Wim Leers β
- Issue was unassigned.
- Status changed to Fixed
about 1 month ago 5:28pm 31 July 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
This introduced a small regression: π First `preview` request fails to generate a response for empty layout Needs review .
Automatically closed - issue fixed for 2 weeks with no activity.