- Issue created by @lauriii
- ð§ðŠBelgium Wim Leers Ghent ð§ðŠðŠðš
Clarifying issue title.
- Issue was unassigned.
- ð§ðŠBelgium Wim Leers Ghent ð§ðŠðŠðš
Unassigning Ben because #3462441-6: Contextual form values need to be integrated with Redux â is more important.
- First commit to issue fork.
- ðšðļUnited States bnjmnm Ann Arbor, MI
The MR I pushed has this working - maybe there's a slicker way but this is what I figured out. It will need tests either way but I'm needed elsewhere for a bit so leaving this unassigned in case someone wants to add those.
- Assigned to jessebaker
- Status changed to Needs review
about 2 months ago 7:01am 23 July 2024 - ð§ðŠBelgium Wim Leers Ghent ð§ðŠðŠðš
@jessebaker, didn't you intentionally use inline styles for the
my-hero
andmy-section
components in ð Add some basic example SDCs Fixed ? Objections to changing that? - ðŽð§United Kingdom jessebaker
I only used inline styles specifically because it wasn't yet possible to load in assets (JS/CSS) when adding a new component but I still wanted them to look nice. This work adds the ability to load in CSS so, yes, get rid of those in-line styles!
- ð§ðŠBelgium Wim Leers Ghent ð§ðŠðŠðš
YAY! ð I'd swear I read something you wrote along the lines of "component with inline styles to verify that works correctly, too" â but my memory must be fooling me then!
- Assigned to bnjmnm
- Status changed to Needs work
about 2 months ago 11:48am 23 July 2024 - ð§ðŠBelgium Wim Leers Ghent ð§ðŠðŠðš
@bnjmnm Is this ready to be converted into an MR?
- Status changed to Needs review
about 2 months ago 7:14pm 24 July 2024 - ðšðļUnited States bnjmnm Ann Arbor, MI
Looks like this
It does look slightly different because the hero component intentionally had vh styling to confirm a specific fix for vh-in-iframe worked.
But! That fix only works on inline styles, which are no longer being used. An issue has been opened for that ð VH units fix only works for inline styles Active
and in the meantime I prefer the less huge hero elements - easier to manually test things.....
Also added an assertion in xb-general that confirms the SDC css loads in the iframe.
- Issue was unassigned.
- Assigned to bnjmnm
- Status changed to Needs work
about 1 month ago 1:15pm 25 July 2024 - ð§ðŠBelgium Wim Leers Ghent ð§ðŠðŠðš
Looks great, just one question about what these "non-components" are ð
Also: END-TO-END CYPRESS TEST!!!!!!! ðĨģ
- Issue was unassigned.
- Status changed to RTBC
about 1 month ago 1:32pm 25 July 2024 - ð§ðŠBelgium Wim Leers Ghent ð§ðŠðŠðš
@bnjmnm clarified: "non-components" is currently only
root
(the client equivalent of\Drupal\experience_builder\Plugin\DataType\ComponentTreeStructure::ROOT_UUID
on the server), but it may be non-SDC components once ðą [META] Support component types other than SDC Needs work lands. ð -
Wim Leers â
committed a7536ec2 on 0.x authored by
bnjmnm â
Issue #3462450 by bnjmnm, Wim Leers: Load assets inside preview...
-
Wim Leers â
committed a7536ec2 on 0.x authored by
bnjmnm â
- Status changed to Fixed
about 1 month ago 1:35pm 25 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.