Remove unnecessary margin in node form meta (sidebar) accordions

Created on 25 July 2024, 4 months ago
Updated 15 August 2024, 3 months ago

Problem/Motivation

It's ugly and not needed. Check the margin-bottom on the .claro-details:

I suggest we remove it by adding this CSS:

.entity-meta.accordion .claro-details {
    margin-bottom: 0;
}

Which results in:

🙏🏻

Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇹Italy kopeboy Milan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kopeboy
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • I have checked the issue and made the necessary changes according to the proposed solutions.
    Here I am sharing the SS:

  • 🇭🇺Hungary djg_tram

    Thanks, I had other a few other changes lined up, so I added it directly instead of the PR.

  • Status changed to Fixed 4 months ago
  • @djg_tram
    Glad I could help to fix the issue!
    I see I have not been credited for helping to fix the issue. Is there anything missing from my end?

  • 🇭🇺Hungary djg_tram

    Both the commit and the actual changelog of the new version refer to this issue. I'm not sure D.o allows us anything more than that but do tell me if I missed something.

  • @djg_tram
    I think credit can be given from here for those who contribute.

  • 🇩🇰Denmark ressa Copenhagen

    Thanks everyone for making Claro Compact compact!

    @djg_tram: Maintainers need to actively add credit to community members helping out in issues. This was previously done automatically. You can follow the "Granting credit to issue contributors" link under "Credit & committing" at the bottom of this page for details.

    All you need to do is probably check the three "By" boxes under "Credit & committing" and click "Save", and the credit will be given to those, who made this improvement happen.

    For example, as you can see under his profile https://www.drupal.org/u/kopeboy , has not been given any Claro Compact credit.

    As a user, it would have made the changes more transparent, if you had created a separate issue and MR for your improvements, and had simply committed this MR. But I can also see how this could seem like too much effort, for too little.

  • 🇭🇺Hungary djg_tram

    Those checkboxes, unless I'm mistaken, only work when accepting a PR, don't they?

    I'm active in a couple of other dev communities where this is handled automatically, yes. It isn't advantageous at all that D.o made it that convoluted, also including how to make a new release. But in one point you're not mistaken, I'd consider it totally unnecessary to create PRs for my own changes and do the whole routine in an even more convoluted way.

    I certainly doesn't want to conceal contributions, quite the opposite, I'm grateful for them. I could've accepted the PR in the first place but frankly, both changes were so minor that, given the extra complexities of the D.o process in general, this seemed much more efficient. I never intended to create animosity, so I apologize if someone feels so, but I'm not sure I can change those boxes now after the fact.

  • 🇩🇰Denmark ressa Copenhagen

    Thanks! @kopeboy is now credited for this contribution in this issue:

    Credited on 40 fixed issues

    • Drupal core, 4 issues
    • Claro Compact, 1 issue
    • [...]

    https://www.drupal.org/u/kopeboy

    Those checkboxes, unless I'm mistaken, only work when accepting a PR, don't they?

    No, they are in fact on an issue basis ... You could consider skimming the "Granting credit to issue contributors" page?

    https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...

    I feel no animosity at all, quite the opposite. I am very grateful that you created this project in the first place, it serves an important role for those of us who like a compact administration theme. And you should run this project how you see fit. All I am saying is that if the regular, boring processes were used, things would be more transparent, and some processes taken care of by the system, we as users can follow along in the changes and where they happened, and so on.

    It's unfortunate that mass MR's ("credit gaming") resulted in automatic crediting for MR's and similar getting removed ... Anyway, all this will soon be history, when the Drupal issue system migrates to Gitlab, which has automatic crediting, and more elegant tools for project administration.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024