Fix diff 2.x integration

Thanks for this! Any chances you could provide steps to reproduce?

@mandclu I've never used this module but I maintain the Diff module. I had similar issue with another module so I've created issues for all modules extending this class.

You'd just need to install Diff 2.x and diff something using this module's field type.

I can confirm the above. With the Smart Date and Diff modules enabled:

1. Add a Smart Date field to any given content type
2. Create a node of the content type with the Smart Date field
3. Update the node to create a revision - note that you don't have to fill out the Smart Date field
4. Compare the new revision using the Diff module through the node's revision page

I can confirm with above. I had to do the same fixes on one of our custom modules earlier today.

+1 for RTBC.
Thanks @acbramley.

However, the same problems occur in Address, Dynamic Entity Reference, Office Hours modules. #3480456-Fatal error occurs 🐛 Fatal error occurs Active
Maybe other modules that I don't know about also have this problem.

Wouldn't it be better to approach the issue through the Diff module?
Because it may be necessary to integrate a separate solution for each different module.

Declaring return types is a best practice, and may soon be officially declared as a requirement in core. Thanks @acbramley for identifying this and posting a fix. Merged in.

Hi,

This patch was applied to the 4.1.x branch, but it's not included in the 4.2.0 release. Fortunately, the patch still applies fine for me against that release.

I've reopened the issue so this can get fixed in the current branch.

Thanks for catching that @micahw156. This has now also been applied to the 4.2.x branch, and I will roll a new release shortly.

Thank you, @mandclu!

Automatically closed - issue fixed for 2 weeks with no activity.