"Webform submissions" view default display does not have any access restriction

Created on 22 July 2024, 3 months ago
Updated 23 August 2024, about 2 months ago

Problem/Motivation

It is a bad practice to have an unprotected view.

Steps to reproduce

Install webform.
The "Webform submissions" view default display does not have any access check.
Any new display added to this view inherits this and is unprotected.

Proposed resolution

It should at least require the access content permission (or maybe something more specific?).

🐛 Bug report
Status

Needs work

Version

6.3

Component

Code

Created by

🇫🇷France prudloff Lille

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @prudloff
  • Status changed to Needs review 3 months ago
  • Pipeline finished with Failed
    3 months ago
    Total: 2058s
    #231396
  • 🇭🇺Hungary mxr576 Hungary

    For sure this module must not depend on the "View published content" permission. Depending on "access content" permission usually leads to security issues, just check the root cause behind some some SA-s.

  • 🇫🇷France prudloff Lille

    I guess "administer webform submission" would be a more secure default value?

  • Status changed to Needs work about 2 months ago
  • 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    All the view displays are embeds. Is the default actually used anywhere? The permissions should probably be administer webform submission. Tests will need to be updated.

  • Pipeline finished with Success
    about 2 months ago
    Total: 184s
    #269776
  • Pipeline finished with Success
    about 2 months ago
    Total: 175s
    #269778
  • Pipeline finished with Success
    about 2 months ago
    Total: 279s
    #269870
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1496s
    #271793
Production build 0.71.5 2024