- Issue created by @vishalkhode
- 🇮🇳India vishalkhode
Cherry-picked @chandu7929 the commit from 📌 Automated Drupal 11 compatibility fixes for scheduler Active .
- Issue was unassigned.
- Status changed to Needs review
8 months ago 3:55pm 22 July 2024 - Status changed to RTBC
8 months ago 9:40am 24 July 2024 - 🇮🇳India vishalkhode
Hi @jonathan1055
Can you review/merge the changes as I've rebased now with 📌 Gitlab PHPunit job at Next Major needs D11-compatible test dependencies Fixed .
Thanks. - 🇬🇧United Kingdom jonathan1055
In due course, yes. You do't need to prompt me :)
I am working on 📌 Call to undefined method getName when running PHPUnit tests on Drupal 11 Fixed and 📌 Remove default_argument_skip_url key from view configurations Fixed
The other main problem is 📌 Fix: The update to convert "numeric" arguments to "entity_target_id" is deprecated Needs review - 🇬🇧United Kingdom jonathan1055
Previous tests had
Data Provider method Drupal\Tests\scheduler\Functional\SchedulerDefaultTimeTest::dataStandardEntityTypes() is not static
All of these errors have been removed with the MR
Accesing
$this
in data providers is no longer allowed, so these have been replaced withself::dataStandardEntityTypes()
. The only place where hardcoded entity types have been used is in the definition of the two functions. There is no simple way round this, so we accept that this is duplicated hard-coding.Thanks. Merged and fixed
-
jonathan1055 →
committed 65c355ae on 2.x authored by
vishalkhode →
Issue #3463141 by jonathan1055, vishalkhode, deepakkm: Update...
-
jonathan1055 →
committed 65c355ae on 2.x authored by
vishalkhode →
- Status changed to Fixed
8 months ago 12:59pm 25 July 2024 - 🇬🇧United Kingdom jonathan1055
The credit I gave in #9 also got lost, so re-doing that too.
Automatically closed - issue fixed for 2 weeks with no activity.
- Merge request !167Issue #3463141 Update DataProvider methods to static → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
I also did the equivalent for 8.x-1.x
https://git.drupalcode.org/project/scheduler/-/commit/b7674877fb2289b082...