- Issue created by @vishalkhode
- First commit to issue fork.
- Status changed to Needs review
5 months ago 11:54am 3 July 2024 - Status changed to RTBC
5 months ago 7:41pm 3 July 2024 - 🇬🇧United Kingdom jonathan1055
Changed parent to related issue.
The phpunit tests all fail at D11. That is not necessarily the fault of this MR, but the overall 'next major' testing needs to be sorted out before I can release a Drupal 11 compatible version of Scheduler.
- 🇮🇳India vishalkhode
Hi @jonathan1055
Yes, there are couple of Drupal 11 tests failing (not all). I've described the complete Drupal 11 status here 📌 Automated Drupal 11 compatibility fixes for scheduler Active . Also, I've added some commits in 📌 Automated Drupal 11 compatibility fixes for scheduler Active to run PHPUnit tests on Drupal 11. Can we merge changes for this ticket as we need to fix this for Drupal 11.The phpunit tests all fail at D11. That is not necessarily the fault of this MR, but the overall 'next major' testing needs to be sorted out before I can release a Drupal 11 compatible version of Scheduler.
- Merge request !154Removed the default_argument_skip_url view filter setting. → (Closed) created by vishalkhode
- 🇬🇧United Kingdom jonathan1055
Thanks for making this MR. Just checked locally and using toString() actually provides more information than we had before.
getName() returns
testViewScheduledContentOverview with data set "#commerce_product"
toString() returns
Drupal\Tests\scheduler\Functional\SchedulerViewsAccessTest::testViewScheduledContentOverview with data set "#commerce_product" ('commerce_product', 'test_product')
But this should not affect the outcome of the
stristr()
condition -
jonathan1055 →
committed cfe0ee41 on 2.x authored by
deepakkm →
Issue #3458430 by deepakkm, vishalkhode: Call to undefined method...
-
jonathan1055 →
committed cfe0ee41 on 2.x authored by
deepakkm →
- Status changed to Fixed
4 months ago 10:51am 25 July 2024 - 🇬🇧United Kingdom jonathan1055
Previously we had errors in PHPstan
Line tests/src/Functional/SchedulerBrowserTestBase.php ------ ------------------------------------------------------------------------ 59 Call to an undefined method Drupal\Tests\scheduler\Functional\SchedulerBrowserTestBase::getName().
etc,
and with this MR the PHPstan Next Major is green and clean.The PHPUnit tests also all had
Error: Call to undefined method Drupal\Tests\scheduler\Functional\the-test-name::getName()
and these are now solved with this MR.
Also, the tests pass at Current and Previous Major (so we maintain backwards compatibility with Drupal 9.5)
Thank you @deepakkm and @vishalkhode. Merged and fixed.
Automatically closed - issue fixed for 2 weeks with no activity.