- Issue created by @catch
- Status changed to Needs review
about 1 month ago 1:39am 29 July 2024 - 🇬🇧United Kingdom catch
eslint doesn't appear to have a verbose option, so it's hard to show this definitely working, but
https://git.drupalcode.org/project/drupal/-/jobs/2258295 is a job from a sandbox MR, where the cspell and phpstan jobs both had cache hits, and eslint running with the same logic. eslint job completed in 51 seconds.https://git.drupalcode.org/project/drupal/-/jobs/2257804 is a job with the current logic and the eslint job took 1m45s.
You can also see that the cache warming job generates the .eslintcache file correctly: https://git.drupalcode.org/project/drupal/-/jobs/2258024
I also tested the same command locally and the caching worked there.
- 🇬🇧United Kingdom catch
We should do eslint and stylelint in a single PR since their cache strategies are the same.
https://git.drupalcode.org/project/drupal/-/jobs/2259023 this shows stylelint caching working in my sandbox branch/MR with the cache target pointing to itself.
- 🇬🇧United Kingdom catch
📌 Use artifacts to share the phpstan result and cspell caches from core to MRs Downport is in, so rebased here and unpostponing.
- Status changed to RTBC
about 1 month ago 12:27am 4 August 2024 - 🇺🇸United States smustgrave
per the slack conversation @catch shared this https://git.drupalcode.org/project/drupal/-/merge_requests/8952/diffs which believe shows this working. Going to mark.
- Status changed to Needs work
about 1 month ago 9:37pm 6 August 2024 - Status changed to RTBC
about 1 month ago 11:19pm 6 August 2024 - 🇬🇧United Kingdom catch
Good spot on the MR, since it's a trivial change, moving back to RTBC.
- 🇫🇷France nod_ Lille
- Status changed to Fixed
about 1 month ago 11:42pm 6 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.