Additional features (block visibility, routes, permissions ...)

Hi
The first two sound like a perfect use case for our original feature flag... a module that you install/uninstall.
The third one makes me feel a bit icky. I would prefer selective preprocess hooks over a global twig extension.

LR

Hey!
In the meantime I published my module here: https://www.drupal.org/project/featureflags_extensions →

The twig extension is just a wrapper for FeatureFlag::isActive($flag_id), usable in twig like this: {% if featureflag_active('flag') %}

The other two features however are more "intrusive", for the permissions part I found no other solution than overriding the global PermissionsChecker service.

If you want you can take a look at the code and let me know what you think! I would still be open to include this in the main featureflags module.

Setting to RTBC to get some maintainer eyeballs on this. Nobody's going to start working on this until they sign off on it.

More up-to-date title.

Hey, I'm happy keeping them separate, core took a different approach (using modules instead of feature flags) so I think the feature set we have here is probably enough for now.

Let's update the status then.

I've thought about this overnight and I'd be happy to join forces if the new features came with test coverage. If that's not feasible, then yeah let's keep them separate

Let's just not merge it here until they're in.