Deprecate LibraryDiscovery and use LibraryDiscoveryCollector instead

The test coverage removed here was added in #2378263: hook_library_alter() must be manually invoked by users of LibraryDiscovery, and has no test coverage → , this add a hook_library_alter:

  public function getLibrariesByExtension($extension) {
-    return $this->collector->get($extension);
+    if (!isset($this->libraryDefinitions[$extension])) {
+      $libraries = $this->collector->get($extension);
+      $this->libraryDefinitions[$extension] = [];
+      foreach ($libraries as $name => $definition) {
+        // Allow modules and themes to dynamically attach request and context
+        // specific data for this library; e.g., localization.
+        $library_name = "$extension/$name";
+        $this->moduleHandler->alter('library', $definition, $library_name);
+        $this->libraryDefinitions[$extension][$name] = $definition;
+      }

Then we removed hook_library_alter() in #2472547: Remove deprecated hook_library_alter() → and the test was left testing the static caching in LibraryDiscovery, but without checking whether it was still necessary or not.

Let's do the deprecation here.

Once it's merged, a couple of the methods are redundant, so we should probably deprecate those too, but maybe those in a follow-up.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Errm, needs review.

Deprecation seems fine, version wise.

Not 100% if all deprecations need a test to make sure the deprecation is returned. I feel like we know that feature works.

Not 100% if all deprecations need a test to make sure the deprecation is returned. I feel like we know that feature works.

Generally I think we should not do this, and only test deprecations triggered by actual backwards compatibility logic rather than from within deprecated code that's going to be removed. It takes time to write the test, run them every CI run, then remove them again, and they don't tell us much.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

bot has issues

nod_ → closed merge request !8864

Committed 1c7a0b5 and pushed to 11.x. Thanks!

nod_ → closed merge request !9207

had to fix the commit since 🐛 Single directory component CSS asset library not picked up in admin theme immediately after module install without cache clear Active introduced a new use of the deprecated method

Automatically closed - issue fixed for 2 weeks with no activity.