- Issue created by @n.ghunaim
- Merge request !17Issue #3462855 by n.ghunaim: Add ckeditor5-styles library with dependencies from other used components to use it for ckeditor5 styles → (Merged) created by n.ghunaim
- Status changed to Needs review
4 months ago 8:20am 8 August 2024 -
rajab natshah →
committed c3ab47a3 on 2.0.x authored by
n.ghunaim →
Issue #3462855 by n.ghunaim: Add ckeditor5-styles library with...
-
rajab natshah →
committed c3ab47a3 on 2.0.x authored by
n.ghunaim →
- Status changed to Fixed
3 months ago 5:20pm 19 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇩🇪Germany stefan.korn Jossgrund
I think there is an issue with this, when trying to override the root component ✨ Add a Root component as a Base, Contains root CSS3 Bootstrap variables to Varbase Components Fixed in your theme. The ckeditor5-styles do not respect the override and you cannot easily override ckeditor5-styles dependencies in your custom theme yourself ✨ Allow overriding/disabling base theme's ckeditor5-stylesheets value Active (I am not even sure that the workaround given there does actually work. did not get it to work at least).
So if the ckeditor5-styles dependencies are called you get the root.css from the theme and from varbase_components and the order of appearance does matter. In my case the root.css from varbase_components came after the one from the theme. And anyway it does not look correct that both are called.
- 🇩🇪Germany stefan.korn Jossgrund
Okay, seems like one can override the ckeditor5-styles from varbase_components module as follows:
define a library in your_theme.libraries.yml as follows
ckeditor5-styles: dependencies: - core/components.your_theme_components--root - core/components.your_theme_components--alert - core/components.your_theme_components--callout
and then in your_theme.info.yml add this to libraries_override:
varbase_components/ckeditor5-styles: your_theme/ckeditor5-styles
not sure if this is already pointed out somewhere.