- Issue created by @pdureau
- π«π·France pdureau Paris
I have started a table to follow the changes (still empty, but let's work on it the next days): https://docs.google.com/spreadsheets/d/1uLGS_knoJ5dQ96lh2pmEUnthzok28K1l...
- π«π·France pdureau Paris
Also, add an annotation in the messages which are addressed to component authors targeting UI Patterns instead of low-level SDC. For example, "You should declare a story in the definition"
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
And perhaps whether it's a Twig thing vs SDC thing, e.g.
starshot_demo:button Error The exact same as just testing the Twig 75 {% if attributes is not empty %}{{- attributes|raw -}}{% endif %}
Twig level :wink:: "is not empty" is useless except when Twig is configured in a very specific way, whcih is not the case in Drupal
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Not to do with wording but it would be nice to be able to just get Schema warnings/errors or just Twig and to be able to "turn off" some things (e.g. Notices).
Also, should the "Unknown variable: is_dismissable" in the Twig maybe show up as a notice in the schema list? Not sure but perhaps easier if people are focused on fixing the schema vs the twig.
- π«π·France pdureau Paris
Thanks for your feedbacks. We will work on this in second half of August.
- Issue was unassigned.
- π«π·France pdureau Paris
Beta2 is coming soon and we are late, so let's do only this for beta2:
From error to warning, related to components embedding:
- Use slots instead of hard embedding a component in the template with `embed` >
- Forbidden Twig function: `block`. Use slots instead of hard embedding a component in the template.
From error to warning, related to Twig condition testing:
- The exact same as just testing the variable, empty is not needed.
- Not needed in Drupal because strict_variables=false.
Other stuff:
- You should declare a story in the definition > To remove because we will remove the stories from the definition anyway
I will move everything else, including the wording, to beta3
- First commit to issue fork.
- Merge request !201Issue #3462737 by kristen pol: [2.0.0-beta2] Component validator wording β (Merged) created by mogtofu33
- Status changed to Needs review
2 months ago 12:25pm 11 September 2024 - π«π·France mogtofu33
Done changes requested in #3462737-9: [2.0.0-beta2] Component validator wording β
-
pdureau β
committed eb18e501 on 2.0.x authored by
mogtofu33 β
Issue #3462737 by mogtofu33, pdureau, kristen pol: Component validator:...
-
pdureau β
committed eb18e501 on 2.0.x authored by
mogtofu33 β
- Status changed to Fixed
2 months ago 12:57pm 11 September 2024 - π«π·France pdureau Paris
Great. Merged.
Follow-up π [2.0.0-beta3] Component validator wording Active
- Status changed to Fixed
2 months ago 7:25pm 15 September 2024