- Issue created by @alexpott
- Status changed to Needs work
5 months ago 8:59am 24 July 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
📌 Use selenium/standalone-chrome instead of our chromedriver image Needs work has landed
- Status changed to Needs review
5 months ago 2:38pm 31 July 2024 - Status changed to Needs work
5 months ago 2:50pm 1 August 2024 - 🇺🇸United States smustgrave
Seems some work still going on in 📌 Use selenium/standalone-chrome instead of our chromedriver image Needs work
- Status changed to Needs review
5 months ago 10:52pm 1 August 2024 - 🇺🇸United States smustgrave
MR appears to need rebase and has test failures too
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@smustgrave yeah I'm waiting on upstream changes - this is all in the issue summary. The changes necessary to make tests on firefox can stll be reviewed. Hence the issue status.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
We're green on firefox and chrome with no hacks to the codebase. Upstream fixes have been merged - thanks @justafish and @longwave.
This is now very ready for review.
- 🇫🇷France andypost
Quickly skimmed and it's mostly test changes, and new Todo needs issue
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I think the @todo's should be decided here - they are really about the issue - i.e should be testing things that seem untestable on firefox - or am I wrong and what we have here is a detectable firefox bug... for example is text just not appearing in firefox even though it is in chrome.
- 🇺🇸United States smustgrave
Would the todo's be good follow ups tagged novice?
- 🇺🇸United States smustgrave
just following up if the todos should be follow ups?
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States smustgrave
Seems to have test failures and may be waiting on other tickets right?
What’s a good way to review this one?
- Status changed to Needs work
about 1 month ago 10:42pm 17 November 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
