- Issue created by @lauriii
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
This may lead into error scenarios, like for example if the component had property expressions in its properties. In this scenario we should display the property expression as "missing". The user can either fill in it manually, or map it to another property.
If the entire JSON structure is copied, I don't see how this could fail? 🤔
- 🇫🇮Finland lauriii Finland
This might be something we should give further consideration but I would imagine users would not expect that copying a component also copies the property expressions source data. This means that copying a component to a new host entity could lead into situation where property expression could be pointing to a target which doesn't exist in the new host entity.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
This means that copying a component to a new host entity
Ah, yes.
StaticPropSource
s would copy over just fine, but notDynamicPropSource
s — for these, users should indeed be prompted.That's also what the
DynamicPropSoruce::$expression
is for:\Drupal\experience_builder\PropExpressions\StructuredData\StructuredDataPropExpressionInterface::isSupported()
literally is designed to allow detecting this 👍IOW: the back end already has the necessary infrastructure.
- 🇫🇮Finland lauriii Finland
Adding this to the board as a potential delighter to add.