- Issue created by @catch
- π¬π§United Kingdom catch
Before:
../vendor/bin/phpunit modules/field/tests/src/Functional/Number/NumberFieldTest.php PHPUnit 10.5.26 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.8 Configuration: /var/www/html/core/phpunit.xml ..... 5 / 5 (100%) Time: 00:28.764, Memory: 4.00 MB
After:
../vendor/bin/phpunit modules/field/tests/src/Functional/Number/NumberFieldTest.php PHPUnit 10.5.26 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.8 Configuration: /var/www/html/core/phpunit.xml .... 4 / 4 (100%) Time: 00:24.821, Memory: 4.00 MB OK (4 tests, 124 assertions)
Only saves about 5 seconds, but seeing if we still need group #slow to stop it overhanging other tests now.
- Status changed to Needs review
5 months ago 7:57am 19 July 2024 - π¬π§United Kingdom catch
Test shows up in the middle of the run on https://git.drupalcode.org/project/drupal/-/jobs/2167447 so enough to remove group #slow for me.
- Status changed to RTBC
5 months ago 2:10pm 19 July 2024 - πΊπΈUnited States smustgrave
Seems straightforward and no coverage loss.
- π¬π§United Kingdom longwave UK
Committed and pushed 63bc78c2d4 to 11.x and ee32e930be to 11.0.x and a8bb272ff9 to 10.4.x and 9320092df7 to 10.3.x. Thanks!
-
longwave β
committed 9320092d on 10.3.x
Issue #3462556 by catch: Consolidate two test methods in NumberFieldTest...
-
longwave β
committed 9320092d on 10.3.x
-
longwave β
committed a8bb272f on 10.4.x
Issue #3462556 by catch: Consolidate two test methods in NumberFieldTest...
-
longwave β
committed a8bb272f on 10.4.x
-
longwave β
committed ee32e930 on 11.0.x
Issue #3462556 by catch: Consolidate two test methods in NumberFieldTest...
-
longwave β
committed ee32e930 on 11.0.x
- Status changed to Fixed
5 months ago 7:48pm 19 July 2024 -
longwave β
committed 63bc78c2 on 11.x
Issue #3462556 by catch: Consolidate two test methods in NumberFieldTest
-
longwave β
committed 63bc78c2 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.