- Issue created by @joegraduate
- Assigned to joegraduate
- Merge request !99Issue #3462520: Fix backwards-incompatible Json data_parser API change included in 6.0.3 → (Merged) created by joegraduate
- Issue was unassigned.
- Status changed to Needs review
5 months ago 3:37am 19 July 2024 - Status changed to Needs work
5 months ago 2:52pm 19 July 2024 - Status changed to Needs review
5 months ago 5:36pm 19 July 2024 - 🇺🇸United States joegraduate Arizona, USA
Applied suggestions from @lucashedding and a couple of other changes. I think this is ready for review again.
- Status changed to RTBC
5 months ago 5:46pm 19 July 2024 -
heddn →
committed b799318c on 6.0.x authored by
joegraduate →
Issue #3462520 by joegraduate, heddn: Fix backwards-incompatible Json...
-
heddn →
committed b799318c on 6.0.x authored by
joegraduate →
- Status changed to Fixed
5 months ago 5:57pm 19 July 2024 - 🇮🇱Israel jsacksick
FYI, that change broke all my migrations... After I reverted to 6.0.2, all my migrations ran successfully again...
Not really sure what information I can provide, somehow it seems no rows was detected by the migration. - heddn Nicaragua
https://www.drupal.org/project/migrate_plus/releases/6.0.4 → does include the BC fix now too.
- 🇮🇱Israel jsacksick
After upgrading to 6.0.4, the rows count is 0 for all my migrations, reverting to 6.0.2 fixes the issue...
- 🇭🇺Hungary huzooka Hungary 🇭🇺🇪🇺
@jsacksick, Could you please check whether the
3465782-using-slash-json-parser
branch (MR 102) in 🐛 Using "/" item_selector in Json parser plugin config does not work as expected anymore Needs review fixes the issue you have? - 🇺🇸United States joegl
6.0.4 does not fix this issue. Our custom plugin which extends Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Json::getSourceData is still broken:
PHP Fatal error: Declaration of Drupal\CustomJson\Plugin\migrate_plus\data_parser\CustomJson::getSourceData(string $url): array must be compatible with Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Json::getSourceData(string $url, string|int $item_selector = '')
Automatically closed - issue fixed for 2 weeks with no activity.