- Issue created by @alok_singh
- Merge request !4rocketstar-3461983: Need to fix spacing issue on searched page. ā (Open) created by alok_singh
- Status changed to Needs review
5 months ago 9:46am 17 July 2024 - First commit to issue fork.
- š®š³India Kanchan Bhogade
Hi
I've reproduced the issue but MR 4 failed while applying.Attaching error SS for reference
- Status changed to Needs work
4 months ago 10:06am 20 August 2024 - š®š³India riddhi.addweb
I tried to apply the MR-4[Patch] and it failed while applying. Attaching the SS for the same.
Checking patch assets/css/style.css... error: while searching for: .user-login-form .form-actions {? margin: 0;? }? ======= .search-form .search-advanced {? margin-top: 20px;? }? ? error: patch failed: assets/css/style.css:1247 error: assets/css/style.css: patch does not apply
- šµšPhilippines cleavinjosh
Hi @alok_singh,
Thank you for providing an MR. I applied MR!4, it was applied smoothly and the changes were reflected.
ā rocketstar git:(1.0.x) curl https://git.drupalcode.org/project/rocketstar/-/merge_requests/4.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5099 0 5099 0 0 13675 0 --:--:-- --:--:-- --:--:-- 13670 patching file assets/css/style.css ā rocketstar git:(1.0.x) ā
Before:
After:
Issue/Concern
- The hover effect indicator of the "About searching" link is less visible. Please see video: issue 1
- The spacing between the "About searching" link and the horizontal line of the "Search Results" title is too small.
- The contents are not aligned on the left.
- The spacing between a search results title and description is too small.
- There is an inconsistency of the responsiveness in the tablet view, in mobile view, the number of the results will touch the left screen.
Please see video: issue 5
Please check and advise.
Thank you. - š®š³India jaydeep_patel Ahmedabad
MR!4 applied cleanly, Spacing issue resolved so Moving it to RTBC.
RTBC++Thank you