Need to fix spacing issue on searched page.

Created on 17 July 2024, 5 months ago
Updated 4 September 2024, 4 months ago

Need to fix spacing issue on searched page.

Needs to be styled

šŸ› Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India alok_singh

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alok_singh
  • Pipeline finished with Success
    5 months ago
    Total: 222s
    #226488
  • Status changed to Needs review 5 months ago
  • šŸ‡®šŸ‡³India alok_singh

    After Fixing

  • First commit to issue fork.
  • Pipeline finished with Success
    5 months ago
    Total: 164s
    #226654
  • šŸ‡®šŸ‡³India Kanchan Bhogade

    Hi
    I've reproduced the issue but MR 4 failed while applying.

    Attaching error SS for reference

  • Pipeline finished with Success
    5 months ago
    Total: 165s
    #228496
  • Status changed to Needs work 4 months ago
  • šŸ‡®šŸ‡³India riddhi.addweb

    I tried to apply the MR-4[Patch] and it failed while applying. Attaching the SS for the same.

    Checking patch assets/css/style.css...
    error: while searching for:
    .user-login-form .form-actions {?
      margin: 0;?
    }?
    ======= .search-form .search-advanced {?
      margin-top: 20px;?
    }?
    ?
    
    error: patch failed: assets/css/style.css:1247
    error: assets/css/style.css: patch does not apply
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @alok_singh,

    Thank you for providing an MR. I applied MR!4, it was applied smoothly and the changes were reflected.

    āžœ  rocketstar git:(1.0.x) curl https://git.drupalcode.org/project/rocketstar/-/merge_requests/4.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  5099    0  5099    0     0  13675      0 --:--:-- --:--:-- --:--:-- 13670
    patching file assets/css/style.css
    āžœ  rocketstar git:(1.0.x) āœ—

    Before:

    After:

    Issue/Concern

    1. The hover effect indicator of the "About searching" link is less visible. Please see video: issue 1
    2. The spacing between the "About searching" link and the horizontal line of the "Search Results" title is too small.
    3. The contents are not aligned on the left.
    4. The spacing between a search results title and description is too small.
    5. There is an inconsistency of the responsiveness in the tablet view, in mobile view, the number of the results will touch the left screen.
      Please see video: issue 5

    Please check and advise.
    Thank you.

  • šŸ‡®šŸ‡³India jaydeep_patel Ahmedabad

    MR!4 applied cleanly, Spacing issue resolved so Moving it to RTBC.
    RTBC++

    Thank you

Production build 0.71.5 2024