- Issue created by @Hetal.Solanki
- Issue was unassigned.
- Status changed to Needs work
2 months ago 11:30am 16 July 2024 - 🇩🇪Germany Anybody Porta Westfalica
@Hetal.Solanki left a question. Other part LGTM. Could you please also fix cspell and phpstan?
Command : phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig web/modules/contrib/block_field/
FILE: /var/www/html/d10/web/modules/contrib/block_field/NOTES.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
31 | WARNING | Line exceeds 80 characters; contains 122 characters
34 | WARNING | Line exceeds 80 characters; contains 130 characters
43 | WARNING | Line exceeds 80 characters; contains 84 characters
----------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/src/BlockFieldSelectionManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/src/Plugin/Field/FieldType/BlockFieldItem.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
158 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/src/Plugin/Field/FieldWidget/BlockFieldWidget.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
16 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\Context\ContextRepositoryInterface.
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/src/Plugin/Field/FieldFormatter/BlockFieldLabelFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldDefinitionInterface.
25 | ERROR | [ ] Parameter $current_user is not described in comment
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/src/Plugin/Field/FieldFormatter/BlockFieldFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContextAwarePluginInterface.
215 | WARNING | [x] A comma should follow the last multiline array item. Found: "block_view_{$base_id}"
221 | WARNING | [x] A comma should follow the last multiline array item. Found: "block_build_{$base_id}"
293 | ERROR | [x] Missing function doc comment
295 | ERROR | [x] Expected 1 blank line after function; 0 found
296 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/block_field.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/tests/modules/block_field_widget_test/block_field_widget_test.info.yml
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/tests/modules/block_field_test/block_field_test.info.yml
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/tests/src/Kernel/BlockFieldSelectionTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\TranslationInterface.
48 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
54 | ERROR | [ ] The array declaration extends to column 119 (the limit is 80). The array content should be split up over multiple lines
54 | ERROR | [ ] The array declaration extends to column 118 (the limit is 80). The array content should be split up over multiple lines
59 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/d10/web/modules/contrib/block_field/tests/src/Functional/BlockFieldTest.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
220 | ERROR | [x] Expected 1 blank line after function; 2 found
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------
Time: 995ms; Memory: 12MB
Run PHPCS on Config Pages module.
Fixed the coding standards.
Submit the patch either MR.
Needs work
1.0
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.
@Hetal.Solanki left a question. Other part LGTM. Could you please also fix cspell and phpstan?