Fix phpcs issues

I have fixed some phpcs issuse and some issuses pending could any one solve this problem

Thankyou !

FILE: /var/www/html/drupal-contri-d10/modules/custom/cloud-3461750/modules/cloud_service_providers/openstack/js/openstack_form.js
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 35 | ERROR | String concat is not required here; use a single string instead
---------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/cloud-3461750/modules/cloud_dashboard/css/index.css
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/cloud-3461750/modules/cloud_dashboard/js/index.js
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------

Time: 1 mins, 4.02 secs; Memory: 125.01MB

@bhaveshdas Thank you for your PR.

I appreciate your effort in submitting this patch. I have a few suggestions to improve the code quality and adhere to the coding standards. Due to the number of issues present, I have summarized the key points below rather than commenting on each line individually. Please review these points and make the necessary adjustments:

1. JavaScript is case-sensitive, and the correct boolean and null values are true, false, and null.
2. There are unnecessary spaces within the HTML tags, which prevent the tags from being correctly recognized. While adding spaces can improve readability and indentation, adding unnecessary spaces inside the tags or between attributes can cause the code to malfunction.
3. The proposed patch introduces unnecessary spaces around the ? character in the URL, which could result in an incorrect URL structure.
4. In the line radio_btn = document.querySelectorAll(input[id = 'edit-chart-type-1']);, there is a small mistake in the selector syntax. The spaces around the equals sign (=) in the attribute selector are unnecessary and non-standard. Additionally, using backticks for template literals is not needed in this context.

Hi @yas

I tried to solve all the remaining phpcs errors.
I changed the values from NULL, TRUE and FALSE to correct boolean and null values (true, false, and null) as requested.
I also removed The spaces around the equals sign (=) in the attribute selector as requested.

The remaining tasks as specified in #5 are:

1. There are unnecessary spaces within the HTML tags, which prevent the tags from being correctly recognized. While adding spaces can improve readability and indentation, adding unnecessary spaces inside the tags or between attributes can cause the code to malfunction.
2. The proposed patch introduces unnecessary spaces around the ? character in the URL, which could result in an incorrect URL structure.

Can you please specify where these problems are being faced so that I can work on it?

Thanks and Regards,
Akul

@akulsaxena

Thank you for your suggested patch. I posted my comments. Also, I don't think we need to refactor the order of all the namespaces.

Thanks

@akulsaxena

Since the 8.x branch has been released, so please rebase your base branch from 7.x to 8.x as the latest one. Thanks!

Hi @yas

Thanks for the review
I'll make the necessary changes and rebase the branches soon

I have made all the suggested changes. Will work on rebasing soon

@akulsaxena

Thank you for your suggested patch.

You seem to try to change the lines of entire all the namespace order, however I don't think we need to refactor them.

Also, Since the 8.x branch has been released, so please rebase your base branch from 7.x to 8.x as the latest one. Thanks!

Thanks

@yas
I refactored the line because the PHPCS standards for drupal specified that namespaces should be alphabetically arranged and although they dont affect the code, it is considered good coding practice. Do you want me to change it back to as it was earlier or keep it as it is now?
Will rebase as soon as I make the suggested changes

@akulsaxena

I refactored the line because the PHPCS standards for drupal specified that namespaces should be alphabetically arranged and although they dont affect the code, it is considered good coding practice. Do you want me to change it back to as it was earlier or keep it as it is now?

I checked the Drupal core code, and the use statements for namespaces are basically sorted in a case-insensitive alphabetical order. Since the use statements in our codebase are already sorted alphabetically, please keep them as they are.

Rebased, Please check

@akulsaxena

This one should be merged into 8.x, but you started with the 7.x branch. So can you please create two MRs for 7.x and 8.x?

I found the alphabetical order problem on the 8.x branch at https://git.drupalcode.org/project/cloud/-/jobs/3364912.
If you are trying to fix the use statements for the alphabetical order, can you please try to apply the fixes to the 8.x branch?

Thanks!

Hi @yas

The issue/3461750-fix-phpcs-issues fork doesnt show 8.x branch. What am I supposed to do?

Also, can you please elaborate #16 and let me know what shall I do since I cant find the 8.x branch in the issue fork?

@akulsaxena

Close the current branch and restart.

1. Please create a new branch w/ Version 8.x-dev for the branch 8.x branch on this issue and update the branch.
2. Change the Version to 7.x-dev on this issue and update the branch 7.x.

By the way, your patch has not passed the PHPUnit at https://git.drupalcode.org/issue/cloud-3461750/-/jobs/3366433. Please check your fixes.

Thanks

@yas

Thanks for replying
Will try working on it on monday

Hi @yas

As mentioned in #19, I created a new branch named 8.x-dev and solved the given PHPCS errors and then raised an MR to 8.x. The Issue states that I have to solve the PHPCS errors and I did that and the PHPCS pipeline was then green.

When I ran the pipeline, the PHPCS errors were resolved but The PHPstan pipeline failed because it showed multiple errors saying optional parameter defined before required parameter. Even though it wasn't asked in the issue, I resolved the PHPStan errors as well and ran the pipeline again thus getting the Phpstan pipeline green as well, but the PHPUnit pipeline is still failing due to some errors I'm unable to recognise.

Can you please take a look.

@akulsaxena

Thank you for your efforts. The PHPUnit errors must be fixed before we merge the MR. I assume that all PHPUnit errors are caused by nullable type hint. Therefore I suggest that you can create the MR only focused on the only namespace alphabetical order.

Thanks¥

@akulsaxena

I found the problem on your MR. You changed the order of the arguments to fix the nullable type hints. The way how you fixed broke the signature of the interfaces/methods, therefore obviously the existing code base won't work.

I'll take over this issue.

Thanks!

@all

This issue had been created before a 8.x branch is released; therefore the issue fork doesn't have the 8.x branch. Therefore I cloned this issue to 📌 Comply with Drupal coding standards (34) (phpcs) Needs work . I will close this issue by marking Closed (outdated).

Thanks

Hi @yas,

I worked on this issue and resolved the PHPCS problem. I also received a draft credit for my contribution. However, since the issue was closed as outdated, I wanted to confirm if this credit still counts towards my overall credits. Since I am new to the Drupal community, could you please clarify?

Thank you!

@akulsaxena

Thank you for your contribution and for taking the initiative to work on the PHPCS issue. While the issue may have been closed as outdated, your effort is still appreciated as part of the community's collaborative spirit.

In terms of credits, contributions that result in a merged patch or tangible improvement are typically what count towards formal recognition.
Since the patch in this case did not proceed to completion due to the issue's outdated status, it may not count as a final credit. However, your engagement and attempt to contribute are valuable experiences that will undoubtedly help in future contributions.

I encourage you to continue participating in issues, as every effort builds your understanding of the process and increases the likelihood of future successes. If you have further questions or need guidance on other issues, feel free to ask.

Thanks