- Issue created by @pdureau
- Assigned to Christian.wiedemann
- π©πͺGermany Christian.wiedemann
Christian.wiedemann β made their first commit to this issueβs fork.
- π«π·France pdureau Paris
When i say:
Remove "Field" from fields select list
I mean, going from "Field Title" to "Title", from "Field Body" to "Body". We already know it is a field.
- Status changed to Needs review
about 2 months ago 9:23pm 22 July 2024 - π©πͺGermany Christian.wiedemann
* I removed the title from the fieldset
* Sort the field.
* Remove the field from the list - π«π·France just_like_good_vibes PARIS
hello,
about the change in " src/Plugin/Derivative/EntityFieldSourceDeriverBase.php " in the current MR- 'label' => $this->t("Field @field", ["@field" => $field_data["label"]]), + 'label' => $this->t("@field", ["@field" => $field_data["label"]]),
it may be better to update the label inside child class of EntityFieldSourceDeriverBase class instead of this base class,
because it may have implications on all source plugin derivers.
Here you just wanted to update the "DerivableContextDeriver" right? then you can update the label of derived plugins in that class directly :) - π«π·France just_like_good_vibes PARIS
And that would be interesting also to remove the fieldset (e.g. in that usage of slotForm or propForm)
the simpler the better :) ? - π«π·France pdureau Paris
I am only care about the wording results, if you agree on a simpler way of doing that, let's go :)
- π©πͺGermany Christian.wiedemann
@just_like_good_vibes
* I added functions which can be overwritten by sub classes. Not sure if it is too much. But now it is easy to change the title, description in sub classes.
* I also prefer container but we should do this in the big UI refactor update. - Assigned to just_like_good_vibes
- π«π·France just_like_good_vibes PARIS
Hello, i did not understand your previous comment Pierre,
maybe your assigned me as a mistake?
anyway, i checked the content of the MR. what is done seems visually ok, although i did not tested myself the code. - Assigned to pdureau
-
pdureau β
committed 3814079d on 2.0.x authored by
Christian.wiedemann β
Issue #3461579 by Christian.wiedemann, pdureau: UX of EntityFieldSource
-
pdureau β
committed 3814079d on 2.0.x authored by
Christian.wiedemann β
- Issue was unassigned.
- Status changed to Fixed
about 1 month ago 4:30pm 28 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.