Add "remove button" for configuration theme css variables

Created on 15 July 2024, 5 months ago

Problem/Motivation

The goal here is to add a "remove scope" button on each plugin elements inside the css variables of each theme.
The values are updated dynamically with ajax and saved only when submitting the form using "Save configuration" button.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

1.1

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @niber
  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • Pipeline finished with Success
    5 months ago
    Total: 181s
    #224589
  • Pipeline finished with Success
    5 months ago
    Total: 164s
    #224618
  • Status changed to Needs work 5 months ago
  • 🇫🇷France Grimreaper France 🇫🇷

    Hello,

    Thanks for the MR.

    Before testing, can you please fix the pipeline code quality job?

  • Pipeline finished with Success
    5 months ago
    Total: 159s
    #224721
  • Pipeline finished with Success
    5 months ago
    Total: 167s
    #224726
  • Pipeline finished with Success
    5 months ago
    Total: 182s
    #224731
  • Hi,

    Done ! You can test the MR.

    Thank you in advance

  • Status changed to Needs review 5 months ago
  • Assigned to Grimreaper
  • 🇫🇷France Grimreaper France 🇫🇷
  • Issue was unassigned.
  • Status changed to Needs work 5 months ago
  • 🇫🇷France Grimreaper France 🇫🇷

    I have not given a look at the code.

    So deletion is ok. But when I add then remove without saving the whole form, then there is a problem. See recorded video.

  • Assigned to niber
  • Status changed to Active 5 months ago
  • Pipeline finished with Success
    4 months ago
    Total: 158s
    #245759
  • Status changed to Needs work 4 months ago
  • Needs work :
    Stuck on an issue where the context variable passed to the removeAddedScope() submit function seems to always be the same whatever triggering element is clicked (always the last ?).
    Once we will be able to get this variable, then the formatted data will be sent correctly to the form builder and the remove button will work as expected for the dynamically added scopes.
    Also, for configuration (versioned) scope variables, there may have little adjustments but the system is already implemented (with $this->removedEntries[] array).

  • Assigned to Grimreaper
  • 🇫🇷France Grimreaper France 🇫🇷
  • Assigned to niber
  • Pipeline finished with Success
    4 months ago
    Total: 164s
    #247957
  • Pipeline finished with Success
    4 months ago
    Total: 160s
    #249193
  • Pipeline finished with Success
    4 months ago
    Total: 158s
    #249306
  • Pipeline finished with Success
    4 months ago
    Total: 174s
    #251295
  • Issue was unassigned.
  • Update : Deletion for versioned scope elements and deletion for dynamically added scope elements is ok, there is still the case when data is not filled in scope/value couple to fix, because $form_state->getValues([...]); won't retrieve the scope if not filled with data, and then won't delete it correctly.

  • Pipeline finished with Success
    4 months ago
    Total: 190s
    #252425
  • First commit to issue fork.
  • 🇫🇷France maboy

    Hello,

    I've just fixed the case when data is not filled in scope/value.
    Need test now.

    Regards,

  • Pipeline finished with Success
    about 1 month ago
    Total: 242s
    #338861
  • 🇫🇷France Grimreaper France 🇫🇷
  • 🇫🇷France Grimreaper France 🇫🇷

    Hello,

    Thanks for the work done here, almost done.

    I fixed PHPCS but found a bug and added a review comment.

Production build 0.71.5 2024