- Issue created by @niber
- Merge request !19Issue #3461420: Add "remove scope" button for configuration theme css variables → (Open) created by niber
- Issue was unassigned.
- Status changed to Needs review
5 months ago 10:59am 15 July 2024 - Status changed to Needs work
5 months ago 12:07pm 15 July 2024 - 🇫🇷France Grimreaper France 🇫🇷
Hello,
Thanks for the MR.
Before testing, can you please fix the pipeline code quality job?
- Status changed to Needs review
5 months ago 2:49pm 15 July 2024 - Assigned to Grimreaper
- Issue was unassigned.
- Status changed to Needs work
5 months ago 3:48pm 23 July 2024 - 🇫🇷France Grimreaper France 🇫🇷
I have not given a look at the code.
So deletion is ok. But when I add then remove without saving the whole form, then there is a problem. See recorded video.
- Assigned to niber
- Status changed to Active
5 months ago 7:11am 2 August 2024 - Status changed to Needs work
4 months ago 12:47pm 6 August 2024 Needs work :
Stuck on an issue where the context variable passed to the removeAddedScope() submit function seems to always be the same whatever triggering element is clicked (always the last ?).
Once we will be able to get this variable, then the formatted data will be sent correctly to the form builder and the remove button will work as expected for the dynamically added scopes.
Also, for configuration (versioned) scope variables, there may have little adjustments but the system is already implemented (with $this->removedEntries[] array).- Assigned to Grimreaper
- Assigned to niber
- Issue was unassigned.
Update : Deletion for versioned scope elements and deletion for dynamically added scope elements is ok, there is still the case when data is not filled in scope/value couple to fix, because $form_state->getValues([...]); won't retrieve the scope if not filled with data, and then won't delete it correctly.
- First commit to issue fork.
- 🇫🇷France maboy
Hello,
I've just fixed the case when data is not filled in scope/value.
Need test now.Regards,
- 🇫🇷France Grimreaper France 🇫🇷
Hello,
Thanks for the work done here, almost done.
I fixed PHPCS but found a bug and added a review comment.