Contrib.social

Fix phpstan test

Open on Drupal.org →
Created on 13 July 2024, 9 months ago

Problem/Motivation

The phpstan test has a single issue that can be ignored:

 ------ ----------------------------------------------------------------- 
  Line   src/Unstable/Value/NewResourceObject.php                         
 ------ ----------------------------------------------------------------- 
  24     Class Drupal\jsonapi_resources\Unstable\Value\NewResourceObject  
         extends @internal class                                          
         Drupal\jsonapi\JsonApiResource\ResourceObject.                   
 ------ -----------------------------------------------------------------

Let's ignore this to get 100% passing and then require phpstan to pass for future MRs.

📌 Task
Status

Postponed

Version

1.0

Component

Code

Created by

🇯🇵Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ptmkenny
  • Merge request !19fix phpstan test → (Open) created by ptmkenny
  • Pipeline finished with Success
    9 months ago
    Total: 268s
    #223122
  • Status changed to Postponed 9 months ago
  • Comment 9 months ago →
    🇯🇵Japan ptmkenny

    This fixes the phpstan test for D10 but D11 phpstan is reporting the following:

     ------ ------------------------------------------------------------------------------ 
  Line   tests/src/Kernel/ResourceResponseFactoryTest.php                              
 ------ ------------------------------------------------------------------------------ 
  71     Access to an undefined property                                               
         Drupal\Tests\jsonapi_resources\Kernel\ResourceResponseFactoryTest::$account.  
         💡 Learn more:                                                                
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property      
 ------ ------------------------------------------------------------------------------

    In addition, to require phpstan to pass, it would be easier to use the updated GitLab CI template once 📌 Fix phpcs test again and require it to pass so that it doesn't break again Needs review is committed.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024