- Issue created by @ptmkenny
- Status changed to Needs review
over 1 year ago 3:20am 13 July 2024 - 🇯🇵Japan ptmkenny
This MR additionally updates the GitLab CI template to the latest version (removes the giant Drupal logo, etc.; only cosmetic changes).
- Status changed to RTBC
over 1 year ago 10:12am 15 July 2024 - 🇮🇳India dev2.addweb
I have applied the patch cleanly, and the above errors are resolved.
Please check the Screenshots for the same. - 🇯🇵Japan ptmkenny
@nilesh.addweb Thanks for testing.
In the future, for GitLab CI issues, you can see the results of applying the MR by clicking the checkmark icon next to the MR, which will show you the pipelines, including the phpcs test.
- 🇯🇵Japan ptmkenny
Coding standards were updated today, so I updated the MR to incorporate those changes.
- 🇯🇵Japan ptmkenny
This module has some PHP 8.4 deprecations, which are already addressed in the MR, so I'm changing the title because PHP 8.4 has now been released.
- 🇯🇵Japan ptmkenny
Bumping to major because this can block sites on PHP 8.4.
- 🇦🇺Australia acbramley
Not a fan of conflating deprecation fixes for PHP 8.4 with other coding standards cruft, but this would be good to get in.
- First commit to issue fork.
-
mglaman →
committed 5ea3b69c on 8.x-1.x authored by
ptmkenny →
Issue #3461125: Fix phpcs test (address PHP 8.4 deprecations) and...
-
mglaman →
committed 5ea3b69c on 8.x-1.x authored by
ptmkenny →
- 🇺🇸United States mglaman WI, USA
Not a fan of conflating deprecation fixes for PHP 8.4 with other coding standards cruft, but this would be good to get in
Normally I agree, but given it's just adding ? for nullables, I think it is okay.
Automatically closed - issue fixed for 2 weeks with no activity.
