Contrib.social

Use Ubuntu images in all CI environments for core

Open on Drupal.org →
Created on 12 July 2024, 8 months ago
Updated 24 August 2024, 6 months ago

Problem/Motivation

Following 📌 Add testing wtih SQLite 3.45 Fixed there are two flavours of PHP container for CI, php-8.3-apache with SQLite 3.40 and php-8.3-ubuntu-apache with SQLite 3.45. At present only the SQLite tests use the later container.

Some build tests require SQLite even when run on other database drivers and have code that checks the version:

  protected function setUp(): void {
    $sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];
    if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {
      $this->markTestSkipped();
    }

However, this means that these tests are effectively skipped on MySQL/Postgres because their PHP containers run SQLite 3.40 but in 11.x SQLITE_MINIMUM_VERSION is set to 3.45. In turn this resulted in 🐛 GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite Needs review not being noticed for several weeks because most of the time we don't explicitly run tests on SQLite.

Steps to reproduce

Proposed resolution

Use the -ubuntu variant of all containers *except* in 10.x when we explicitly want to test on an older version of SQLite.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

11.0 🔥

Component
PHPUnit  →

Last updated 4 days ago

Created by

🇬🇧United Kingdom longwave UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024