Enabling "pagination text" setting causes slider to disappear

Open on Drupal.org →

Created on 10 July 2024, 4 months ago

Updated 18 July 2024, 4 months ago

Problem/Motivation

I'm working on upgrading Blazy and Splide on one of our sites from the previous major versions. Most of our sliders have just required minor style tweaks, but one of them uses the "Pagination text" setting, and that one's not working. I've tested it both in our own theme, and in Olivero, with the same result: disabling the "Pagination text" setting causes the slider to appear and work as expected (except, of course, the navigation tabs are missing), re-enabling the option causes the slider to disappear again.

This slider is using a custom block type with a paragraphs field. The paragraph type has a media reference field that allows images only, and a text field for the pagination text. I've tested with both the "paragraphs vanilla" formatter and the "entity reference" formatter, with the same result.

Steps to reproduce

I've duplicated this issue on a clean, standard install of Drupal 10.3.1.

- Enable Media, Media Library, Paragraphs, Splide, and any required dependencies.
- Create a paragraph type with a media reference field that allows images, and a text field.
- Create a custom content block type with a paragraphs field allowing that paragraph type.
- Set the custom block formatter to use the paragraphs vanilla splide formatter. Override the pagination option and enable the "Pagination text" option, selecting the text field from your paragraph type. Save the display settings.
- Create a custom block of the new type and add some slides.
- Place the block and see if it displays.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: outdated

Version

2.0

Component

Code

Created by

🇺🇸United States wrd-oaitsd

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @wrd-oaitsd
Comment 4 months ago →
🇺🇸United States wrd-oaitsd
Comment 4 months ago →
🇺🇸United States wrd-oaitsd
This JS error appears in the console when I have the Caption Text option enabled...but it doesn't look especially helpful, since this just appears to be an error handler within drupal.js.
Comment 4 months ago →
🇮🇩Indonesia gausarts
Thank you.

Looks like an unfortunate regression.

Patches are welcome if anyone beats me to it.
Assigned to Tirupati_Singh
Comment 4 months ago →
🇮🇳India Tirupati_Singh
Issue was unassigned.
Status changed to Closed: outdated 4 months ago7:25am 18 July 2024
Comment 4 months ago →
🇮🇳India Tirupati_Singh
Hi @wrd-oaitsd, the issue you have raised has been resolved and you can find the latest code in the 2.0.x-dev branch. Please refer to this issue https://www.drupal.org/project/splide/issues/3457091 🐛 Race condition with instance.options in splide.base.js results in incorrect merged options Fixed , the MR of the issue also fixes your problem. Hoping for a soon new release of this module by the maintainer. I am marking this issue as closed and outdated.

Additionally, for your convenience, I've attached the patch for the issue, the issue will be resolved after applying the patch or else you can use the dev version of the module.
Comment 4 months ago →
🇺🇸United States wrd-oaitsd
Yes indeed, I seem to have a working slider again. Thanks much!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024