- Issue created by @Grimreaper
- Merge request !8728Issue #3460462 by Grimreaper: Change the LB Add block link text to understand... β (Open) created by Grimreaper
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 9:19am 10 July 2024 - π«π·France Grimreaper France π«π·
Attaching patch for Composer usage.
- Status changed to Needs work
about 2 months ago 9:25am 10 July 2024 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- π«π·France pdureau Paris
The little change we are waiting for so long. Thanks you so much.
However, you replaced:
Add block <span class="visually-hidden">in @section, @region region</span>
By:
Add block in region @region <span class="visually-hidden">, section @section</span>
Knowing than
@section
is build like that:$layout_settings['label'] ?? $this->t('Section @section', ['@section' => $delta + 1]);
I would move mentioning "region" because it is obvious for sighted people and visually impaired people have the additional wording, and skip"section" because already part of the label:
Add block in @region <span class="visually-hidden"> region, @section</span>
- Assigned to Grimreaper
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 9:52am 10 July 2024 - π«π·France Grimreaper France π«π·
Thanks for the quick feedback.
I have updated the MR.
In the original title, there is no space after the end of the opening span tag, so resulting in:
Add block in @region <span class="visually-hidden">region, @section</span>
And not:
Add block in @region <span class="visually-hidden"> region, @section</span>
- Status changed to Needs work
about 2 months ago 10:22am 10 July 2024 - π«π·France Grimreaper France π«π·
I guess you wanted to RTBC :)
New patch.
- Status changed to RTBC
about 2 months ago 9:41am 12 July 2024 - π³πΏNew Zealand DanielVeza Brisbane, AU
Thanks for raising an issue! This would need test coverage before it is can be moved to RTBC.
I'm not entirely convinced it is a better UX than the existing setup, but I'd be interested in hearing others opinions on it too
- Status changed to Needs work
about 2 months ago 5:12am 13 July 2024 - π«π·France pdureau Paris
Hi Daniel,
I'm not entirely convinced it is a better UX than the existing setup, but I'd be interested in hearing others opinions on it too
Indeed, in the screenshot you uploaded as an example, the improvment is is not very visible, because the region are called "First", "Second", "Third"...
In the opposite side of the spectrum, you have thos example (each region is a slot of a Bootsrap card) which is unusable without this patch: